ice(4): Add RDMA Client Interface
ClosedPublic
Actions

Authored by erj on Jun 24 2021, 8:07 PM.

Details

Reviewers

stallamr_netapp.com
erj
andrew

Group Reviewers

Intel Networking

Commits

rG152fa6f5b00b: ice(4): Add RDMA Client Interface
rG71c6b6057c2b: ice(4): Add RDMA Client Interface
rG8a13362d49bf: ice(4): Add RDMA Client Interface

Summary

This allows the "irdma" driver to communicate with the ice(4)
driver to allow it access to the underlying device's hardware
resources as well as synchronize access to shared resources.

This interface already existed in the standalone out-of-tree
1.34.2 driver; this commit adds and enables it in the in-kernel
driver.

Signed-off-by: Eric Joyner <erj@FreeBSD.org>

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40402
Build 37291: arc lint + arc unit

Event Timeline

erj created this revision.Jun 24 2021, 8:07 PM

Herald added subscribers: emaste, andrew, imp. · View Herald TranscriptJun 24 2021, 8:07 PM

erj requested review of this revision.Jun 24 2021, 8:07 PM

Harbormaster completed remote builds in B40080: Diff 91322.Jun 24 2021, 8:07 PM

erj added a parent revision: D30888: ice(4): Update to version 0.29.4-k.Jun 24 2021, 8:07 PM

erj added reviewers: stallamr_netapp.com, Intel Networking.

Eric,

I donot see "irdma" available yet in FreeBSD ?

In D30889#694858, @stallamr_netapp.com wrote:

Eric,

I donot see "irdma" available yet in FreeBSD ?

Do you mean in-kernel? It's currently available as an OOT module here:

https://downloadcenter.intel.com/download/30325/irdma-RDMA-FreeBSD-Driver-for-Intel-Ethernet-Controller-E810

In D30889#694862, @erj wrote:

In D30889#694858, @stallamr_netapp.com wrote:

Eric,

I donot see "irdma" available yet in FreeBSD ?

Do you mean in-kernel? It's currently available as an OOT module here:

https://downloadcenter.intel.com/download/30325/irdma-RDMA-FreeBSD-Driver-for-Intel-Ethernet-Controller-E810

Yes, I meant in-tree-kernel version. Do you have plan to upstream OOT irdma driver ?

In D30889#695024, @stallamr_netapp.com wrote:

Yes, I meant in-tree-kernel version. Do you have plan to upstream OOT irdma driver ?

I think we plan on doing an upstream version, but I don't know the timeline yet. I'll have to talk to the FreeBSD RDMA developer.

Rebase on updated parent

Harbormaster completed remote builds in B40402: Diff 91988.Jul 9 2021, 12:19 AM

Rebase on latest main

Harbormaster completed remote builds in B40404: Diff 91990.Jul 9 2021, 12:22 AM

We'll hold off on doing anything with this until we're ready to upstream the actual RDMA driver and associated code; there may be some more changes identified.

Update with latest driver version's interface; now based on 1.34.2-k.

Harbormaster completed remote builds in B44081: Diff 101876.Jan 25 2022, 3:24 AM

erj edited parent revisions, added: D34024: ice(4): Update to 1.34.2-k; removed: D30888: ice(4): Update to version 0.29.4-k.Jan 25 2022, 3:24 AM

erj edited the summary of this revision. (Show Details)

erj added inline comments.Jan 25 2022, 3:26 AM

sys/modules/ice/Makefile
20	We added a hack to the ice module Makefile to compile interface/.m files. These are required for the RDMA client interface, but they don't build as-is like the normal .c files. The source directory doesn't seem to be included by default, so add lines that specifically add them as libraries so that ice_rdma.h can be found and the interface files will compile.