xpt_clone_path originally returned a cam_status, but it doesn't do I/O
and should return an errno instead. I added it last year and it's only
used in one place. It's not yet documented, so no doc changes are
needed.
Sponsored by: Netflix
Differential D30884
cam: change xpt_clone_path to return int imp on Jun 24 2021, 4:59 PM. Authored by Tags None Referenced Files
Subscribers None
Details
xpt_clone_path originally returned a cam_status, but it doesn't do I/O Sponsored by: Netflix Based on Scott's comments on other reviews, make this fit the pattern of returning errno rather than cam_status.
Diff Detail
Event TimelineComment Actions Though it is confusing for xpt_compile_path() and xpt_clone_path() have different return codes. Comment Actions xpt_compile_path is used internally to CAM in 9 places. It's a good candidate as well, so I'll change that too. Comment Actions Although not used in a lot of places, it is used by xpt_create_path which does return a cam_status and is used in a bunch of SIMs, so some care would need to be undertaken to convert that... Either way, I'll followup with a subsequent review. |