Relax the validation added in 24b2f4ea4922 slightly, to allow for raw
event codes obtained from the pmu-events table.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
sys/dev/hwpmc/hwpmc_arm64.c | ||
---|---|---|
186 | I'm not 100% sure, but maybe better to fix requester? |
Comment Actions
Is there a way to tell if a raw event or event code has been asked for on the syscall boundary? In current architecture the event space is 16bit so we can tell the difference, however we shouldn't assume this will never change.
sys/dev/hwpmc/hwpmc_arm64.c | ||
---|---|---|
188 | If we are allowing raw events here could we allow the full 16 bit event space? (10 bit in Armv8.0) |
Comment Actions
There is no way to tell precisely with the current scheme, but I see two ways we might detect this. We can add a new flag, PMC_F_EVENTCODE_RAW and always apply this for pmu-events allocations, or we can add a field to pmc_md_op_pmcallocate for the raw event code. There seems to be more precedent for the latter.