linuxcommon: retire extra module version.
ClosedPublic
Actions

Authored by dchagin on May 23 2021, 9:54 PM.

Details

Reviewers

manu
emaste

Group Reviewers

Linux Emulation

Commits

rGe06cbb2b7ac1: linux_common: retire extra module version.
rG2d7565bbbc53: linux_common: retire extra module version.
rG5184e2da4192: linux_common: retire extra module version.

Summary

The second 'linuxcommon' line was added by r349886
(c66f5b079d2a259c3a65b1efe0f2143cd030dc52) but Linuxulator's modules
dependend on 'linux_common'. To avoid such mistakes in the future
make all modules dependent on 'linuxcommon'.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39449
Build 36338: arc lint + arc unit

Event Timeline

dchagin created this revision.May 23 2021, 9:54 PM

Herald added a reviewer: manu. · View Herald TranscriptMay 23 2021, 9:54 PM

Herald added subscribers: emaste, andrew, imp. · View Herald Transcript

dchagin requested review of this revision.May 23 2021, 9:54 PM

Harbormaster completed remote builds in B39367: Diff 89702.May 23 2021, 9:54 PM

dchagin edited reviewers, added: Linux Emulation; removed: manu.May 23 2021, 9:59 PM

Herald added a reviewer: manu. · View Herald TranscriptMay 23 2021, 9:59 PM

rename module to linuxcommon

Harbormaster completed remote builds in B39447: Diff 89833.May 25 2021, 5:32 PM

emaste added inline comments.May 25 2021, 5:51 PM

sys/compat/linux/linux_common.c
88–89	I'm a little confused, were there other references to `linuxcommon` already, or other reasons `linuxcommon` is preferable to `linux_common`? Could we not instead just change this to `DECLARE_MODULE(linux_common, linux_common_mod, SI_SUB_EXEC, SI_ORDER_ANY);` and move the `MODULE_VERSION(linux_common, 1);` here?