Page MenuHomeFreeBSD

ktrace: Avoid recursion in namei()
ClosedPublic

Authored by markj on May 18 2021, 8:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 7:16 AM
Unknown Object (File)
Sat, Oct 19, 8:33 PM
Unknown Object (File)
Sat, Oct 19, 8:33 PM
Unknown Object (File)
Sat, Oct 19, 8:33 PM
Unknown Object (File)
Sat, Oct 19, 8:23 PM
Unknown Object (File)
Sep 25 2024, 9:13 PM
Unknown Object (File)
Sep 20 2024, 7:48 PM
Unknown Object (File)
Sep 5 2024, 10:10 PM
Subscribers

Details

Summary

I tried fuzzing ktrace(2) with syzkaller and it found the following bug:
sys_ktrace() calls namei(), which may call ktrnamei(). But sys_ktrace()
also calls ktrace_enter() first, so if the caller is itself being
traced, the assertion in ktrace_enter() is triggered. And, ktrnamei()
does not check for recursion like most other ktrace ops do.

Fix the bug by simply deferring the ktrace_enter() call. I believe it
is safe to perform name resolution from sys_ktrace() even when traced.
Also make the parameter to ktrnamei() const and convert to ANSI.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39281
Build 36170: arc lint + arc unit