style: tweak tab after #define advice
ClosedPublic
Actions

Authored by imp on May 13 2021, 9:53 PM.

Details

Reviewers

sef
allanjude
0mp
jhb

Group Reviewers

manpages

Commits

rGab6145c97683: style: tweak tab after #define advice

Summary

Once upon a time, #define<tab> was cultural thing. However, even when it
was promulgated, it was a minority usage. 20 years ago the split was
30k/69k (tab/space) and today the split is 80k/546k (tab/space). Update
guidance to allow either.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39848
Build 36737: arc lint + arc unit

Event Timeline

imp created this revision.May 13 2021, 9:53 PM

Herald added a reviewer: manpages. · View Herald TranscriptMay 13 2021, 9:53 PM

imp requested review of this revision.May 13 2021, 9:53 PM

Harbormaster completed remote builds in B39175: Diff 89167.May 13 2021, 9:53 PM

sef accepted this revision.May 13 2021, 10:01 PM

This revision is now accepted and ready to land.May 13 2021, 10:01 PM

Can we please encourage per-file or per-group consistency? Patches are annoying to read when the a group of #defines randomly switches between styles.

In D30254#679505, @brooks wrote:

Can we please encourage per-file or per-group consistency? Patches are annoying to read when the a group of #defines randomly switches between styles.

Ditto @brooks ; Perhaps a blanket statement near the top that when making minor modifications to existing files, go with the flow, even if it's not strictly conformant to style(9)?

allanjude accepted this revision.May 14 2021, 12:37 AM

0mp accepted this revision.May 17 2021, 3:17 PM

add suggested consistency stuff

This revision now requires review to proceed.May 27 2021, 2:16 PM

Harbormaster completed remote builds in B39514: Diff 90013.May 27 2021, 2:16 PM

jhb added a subscriber: jhb.May 27 2021, 3:32 PM

jhb added inline comments.