Page MenuHomeFreeBSD

imgact_elf: Ensure that the return value in parse_notes is initialized
ClosedPublic

Authored by markj on Apr 25 2021, 11:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 26, 1:30 PM
Unknown Object (File)
Sat, Mar 22, 2:58 AM
Unknown Object (File)
Feb 24 2025, 8:33 AM
Unknown Object (File)
Feb 2 2025, 2:11 AM
Unknown Object (File)
Jan 25 2025, 8:04 PM
Unknown Object (File)
Jan 25 2025, 8:31 AM
Unknown Object (File)
Jan 21 2025, 11:33 PM
Unknown Object (File)
Jan 18 2025, 5:16 PM
Subscribers

Details

Summary

parse_notes relies on the caller-supplied callback to initialize "res".
Two callbacks are used in practice, brandnote_cb and note_fctl_cb, and
the latter fails to initialize res. Try to fix it.

Reported by: KMSAN

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 38857
Build 35746: arc lint + arc unit

Event Timeline

I.e. the only effect of this was that the inner loop from check_note potentially did not stopped after fctl note was handled, but continued till the end of the phdrs.

This revision is now accepted and ready to land.Apr 26 2021, 12:03 AM
In D29986#672701, @kib wrote:

I.e. the only effect of this was that the inner loop from check_note potentially did not stopped after fctl note was handled, but continued till the end of the phdrs.

I think so, yes. I will note this in the commit message.