Use thunks for compat ioctls using struct ifgroupreq.

[jhb]

Summary

Obtained from: CheriBSD
Sponsored by: DARPA

[kib]

sys/net/if.c

2855

Why the change in {} is needed?

[jhb]

sys/net/if.c

2855

For the local 'ifgr' variable.

[kib]

sys/net/if.c

2855

Ok, why is this one-time used variable needed? I mean, you can add ->ifgr_group to the cast expression and for me it is easier to understand.

[jhb]

sys/net/if.c

2855

Ah, this was matching the original code before the addition of ifgr_group_get(). I can make it do it without a local variable though.

[jhb]

• Review feedback.

[kib]

sys/net/if.c

2851–2852

Since you change around these lines, you could also introduce your preferred way to write it

error = if_addgroup(ifp, ...);
if (error != 0)
     return (error);

I am fine either way.

2873–2874

Same there.

[jhb]

sys/net/if.c

2851–2852

I almost did, so this prod is enough for me to fix it. Thanks.