arm64: Fix finding the pmc event ID
ClosedPublic
Actions

Authored by andrew on Apr 6 2021, 8:44 AM.

Details

Reviewers

gnn
ray

Group Reviewers

arm64

Commits

rG19135e372ff1: arm64: Fix finding the pmc event ID
rG24b2f4ea4922: arm64: Fix finding the pmc event ID

Summary

The lower pmc event bits were masked off to find the PMC event ID.
The doesn't work when there are more events. Switch it to use the
offser relative to the first event while also checking the ID is
in the expected range.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Apr 6 2021, 8:44 AM

Herald added subscribers: emaste, imp. · View Herald TranscriptApr 6 2021, 8:44 AM

andrew requested review of this revision.Apr 6 2021, 8:44 AM

Harbormaster completed remote builds in B38354: Diff 86888.Apr 6 2021, 8:44 AM

gnn accepted this revision.Apr 7 2021, 1:05 PM

This revision is now accepted and ready to land.Apr 7 2021, 1:05 PM

Looks fine.
Thanks!

Closed by commit rG24b2f4ea4922: arm64: Fix finding the pmc event ID (authored by andrew). · Explain WhyApr 8 2021, 10:20 AM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG24b2f4ea4922: arm64: Fix finding the pmc event ID.

mhorne added a commit: rG19135e372ff1: arm64: Fix finding the pmc event ID.Jul 29 2021, 3:25 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

hwpmc/

hwpmc_arm64.h

1 line

hwpmc_arm64.c

4 lines

Diff 87011

View Options

sys/dev/hwpmc/hwpmc_arm64.h