Page MenuHomeFreeBSD

kern: pull pru_sockaddr call out into sosockaddr()
ClosedPublic

Authored by kevans on Mar 9 2021, 1:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 30, 12:28 AM
Unknown Object (File)
Sun, Oct 20, 6:55 AM
Unknown Object (File)
Oct 6 2024, 11:30 AM
Unknown Object (File)
Oct 6 2024, 7:41 AM
Unknown Object (File)
Sep 28 2024, 9:13 AM
Unknown Object (File)
Sep 8 2024, 4:22 PM
Unknown Object (File)
Sep 6 2024, 4:29 PM
Unknown Object (File)
Sep 6 2024, 1:30 AM
Subscribers

Details

Summary

We will reuse this in Wireguard to grab the listening port that was
chosen if it was omitted, so we can use a consistent port for udp6 and
export the result to userland.

MFC after: 3 days

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsys/kern/uipc_socket.c:865SPELL1Possible Spelling Mistake
Warningsys/kern/uipc_socket.c:870SPELL1Possible Spelling Mistake
Warningsys/sys/socketvar.h:420SPELL1Possible Spelling Mistake
Unit
No Test Coverage
Build Status
Buildable 37693
Build 34582: arc lint + arc unit

Event Timeline

This method is used in a number of other places - was it your intention to convert them at some point?

This revision is now accepted and ready to land.Mar 9 2021, 2:59 PM

This method is used in a number of other places - was it your intention to convert them at some point?

Yup- I'll make a pass in the next couple of days, since I'm about out of immediate wireguard fun to be had.

melifaro added inline comments.
sys/kern/uipc_socket.c
865

Given other similar functions follow the pattern of so verb something, maybe it's worth naming this sogetsockaddr() or sofillsockaddr() for consistency?

sys/kern/uipc_socket.c
865

Oh, true, sorry; I'll rename it to sogetsockaddr for symmetry with, e.g., in_getsockaddr.

jhb added a subscriber: jhb.

This has been superseded by D30087.