Page MenuHomeFreeBSD

PRR: Avoid accounting left-edge twice in partial ACK.
ClosedPublic

Authored by rscheff on Feb 20 2021, 6:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 22, 10:01 AM
Unknown Object (File)
Sat, Sep 21, 3:45 PM
Unknown Object (File)
Sat, Sep 21, 4:54 AM
Unknown Object (File)
Fri, Sep 20, 6:52 AM
Unknown Object (File)
Wed, Sep 18, 6:45 AM
Unknown Object (File)
Wed, Sep 18, 1:06 AM
Unknown Object (File)
Sun, Sep 15, 8:07 PM
Unknown Object (File)
Sat, Sep 14, 9:02 PM
Subscribers

Details

Summary

After D18624, accounting the advance of the left edge
in a partial ack is already included in
sackhint.delivered_data.

Therefore this is a cumulative error of the
prr_delivered bytes, over the course of multiple
partial acks while lost packets get acknowledged in
sequence.

Test Plan

Corrected behavior, maximum of 2 segments per ACK:

Incorrect behavior due to double-accounting (counterintutively, being more agressive pushing data out - 3 segments per ACK):

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37226
Build 34115: arc lint + arc unit

Event Timeline

rscheff retitled this revision from PRR: avoid accounting left-edge twice in parital ack to PRR: Avoid accounting left-edge twice in partial ACK..Feb 20 2021, 7:42 PM
This revision is now accepted and ready to land.Feb 21 2021, 12:01 AM