Page MenuHomeFreeBSD

PRR: Avoid accounting left-edge twice in partial ACK.
ClosedPublic

Authored by rscheff on Feb 20 2021, 6:39 PM.
Tags
None
Referenced Files
F113724284: D28819.diff
Wed, Apr 2, 3:04 PM
Unknown Object (File)
Feb 24 2025, 4:16 PM
Unknown Object (File)
Feb 4 2025, 7:14 PM
Unknown Object (File)
Feb 3 2025, 12:16 PM
Unknown Object (File)
Jan 24 2025, 4:16 AM
Unknown Object (File)
Jan 24 2025, 3:20 AM
Unknown Object (File)
Jan 24 2025, 3:11 AM
Unknown Object (File)
Jan 15 2025, 10:34 PM
Subscribers

Details

Summary

After D18624, accounting the advance of the left edge
in a partial ack is already included in
sackhint.delivered_data.

Therefore this is a cumulative error of the
prr_delivered bytes, over the course of multiple
partial acks while lost packets get acknowledged in
sequence.

Test Plan

Corrected behavior, maximum of 2 segments per ACK:

Incorrect behavior due to double-accounting (counterintutively, being more agressive pushing data out - 3 segments per ACK):

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rscheff retitled this revision from PRR: avoid accounting left-edge twice in parital ack to PRR: Avoid accounting left-edge twice in partial ACK..Feb 20 2021, 7:42 PM
This revision is now accepted and ready to land.Feb 21 2021, 12:01 AM