riscv: Don't set __NO_TLS to disable some uses of TLS.
ClosedPublic
Actions

Authored by jhb on Feb 16 2021, 6:52 PM.

Details

Reviewers

mhorne
jrtc27
imp

Commits

rGdd176fd7e7b5: riscv: Don't set __NO_TLS to disable some uses of TLS.

Summary

TLS works fine on riscv.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 37063
Build 33952: arc lint + arc unit

Event Timeline

jhb created this revision.Feb 16 2021, 6:52 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 16 2021, 6:52 PM

jhb requested review of this revision.Feb 16 2021, 6:52 PM

Harbormaster completed remote builds in B37063: Diff 84030.Feb 16 2021, 6:53 PM

jhb added a child revision: D28713: mips: Don't set __NO_TLS to disable some uses of TLS..Feb 16 2021, 6:53 PM

jhb added reviewers: mhorne, jrtc27.Feb 16 2021, 6:53 PM

MIPS should work fine too, and PowerPC64 ELFv1 really needs a comment saying why TLS is broken (and what it would take to remove this hack), though I'm unconvinced it is given that e.g. jemalloc doesn't die a horrible death.

mhorne accepted this revision.Feb 16 2021, 8:25 PM

This revision is now accepted and ready to land.Feb 16 2021, 8:25 PM

MIPS is in another review as a child of this. I'll leave it to the ppc folks to look at that one: PowerPC.

Same comment I had on the mips review: why is this no longer needed? is a question that the commit message should answer, imho.

Closed by commit rGdd176fd7e7b5: riscv: Don't set __NO_TLS to disable some uses of TLS. (authored by jhb). · Explain WhyFeb 18 2021, 12:36 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGdd176fd7e7b5: riscv: Don't set __NO_TLS to disable some uses of TLS..

Revision Contents
Changeset List

Path

Size

sys/

cdefs.h

2 lines

Diff 84030

View Options

riscv: Don't set __NO_TLS to disable some uses of TLS.ClosedPublicActions