mips: Don't set __NO_TLS to disable some uses of TLS.
ClosedPublic
Actions

Authored by jhb on Feb 16 2021, 6:53 PM.

Details

Reviewers

jrtc27
imp

Commits

rG24fd63e0970f: mips: Don't set __NO_TLS to disable some uses of TLS.

Summary

TLS works fine on MIPS.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Feb 16 2021, 6:53 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 16 2021, 6:53 PM

jhb requested review of this revision.Feb 16 2021, 6:53 PM

Harbormaster completed remote builds in B37064: Diff 84031.Feb 16 2021, 6:53 PM

jhb added a parent revision: D28712: riscv: Don't set __NO_TLS to disable some uses of TLS..Feb 16 2021, 6:53 PM

jhb added a reviewer: jrtc27.Feb 16 2021, 8:44 PM

why is this no longer needed? why was it done in the first place?

The change itself looks good, but a few words towards answering either of these questions would help our future selves sort this out.

imp accepted this revision.Feb 17 2021, 10:20 PM

This revision is now accepted and ready to land.Feb 17 2021, 10:20 PM

Hmmm, so __NO_TLS was first added in 82dd5016bd749d1d9e1531bd1703aebeecceab34 to support locale extensions in libc. I think it means that the compiler doesn't support TLS in the form of the _Thread keyword. Maybe this was due to GCC 4.2? The log message isn't super clear. It doesn't guard other TLS usage such as in jemalloc which was compiled with GCC 4.2. so it's hard to understand how long this has been rotted.

jhb changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.Feb 17 2021, 11:56 PM

In D28713#643917, @jhb wrote:

Hmmm, so __NO_TLS was first added in 82dd5016bd749d1d9e1531bd1703aebeecceab34 to support locale extensions in libc. I think it means that the compiler doesn't support TLS in the form of the _Thread keyword. Maybe this was due to GCC 4.2? The log message isn't super clear. It doesn't guard other TLS usage such as in jemalloc which was compiled with GCC 4.2. so it's hard to understand how long this has been rotted.

This is good information to include in the commit, since it gives the context for why it was there originally, and why it's no longer needed. 8 years ago is getting into the range of 'overcome by other events and not cleaned up'

Closed by commit rG24fd63e0970f: mips: Don't set __NO_TLS to disable some uses of TLS. (authored by jhb). · Explain WhyFeb 18 2021, 12:36 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG24fd63e0970f: mips: Don't set __NO_TLS to disable some uses of TLS..