Page MenuHomeFreeBSD
Differential D28156

Add missing no-ctfconvert to C generation rules
ClosedPublic
Actions

Authored by andrew on Jan 14 2021, 3:42 PM.
Tags
None
Referenced Files
F108995312: D28156.diff
Thu, Jan 30, 10:27 AM
Unknown Object (File)
Sun, Jan 26, 6:26 PM
Unknown Object (File)
Fri, Jan 24, 5:24 PM
Unknown Object (File)
Sun, Jan 12, 12:26 PM
Unknown Object (File)
Dec 23 2024, 3:35 AM
Unknown Object (File)
Dec 10 2024, 5:17 AM
Unknown Object (File)
Dec 4 2024, 10:06 PM
Unknown Object (File)
Nov 25 2024, 9:51 AM
View All 64 Files
Subscribers
emaste
imp
mmel

Details

Reviewers
emaste
mmel
Commits
rG94611a838866: Add missing no-ctfconvert to C generation rules
Summary

Stop running ctfconvert over generated C files in the kernel by marking
them with no-ctfconvert.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 36199
Build 33088: arc lint + arc unit

Event Timeline

andrew created this revision.Jan 14 2021, 3:42 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptJan 14 2021, 3:42 PM
andrew requested review of this revision.Jan 14 2021, 3:42 PM
Harbormaster completed remote builds in B36199: Diff 82266.Jan 14 2021, 3:42 PM
emaste accepted this revision.Jan 15 2021, 3:27 AM

Looks fine to me. Is there anything specific that made you notice this?

This revision is now accepted and ready to land.Jan 15 2021, 3:27 AM
mmel accepted this revision.Jan 15 2021, 9:09 AM
mmel added a subscriber: mmel.

LGTM. thanks.
It is a bit questionable whether ctfconvert should generate an error in this case (I don't think so), but calling it is clearly unnecessary in this case.

andrew added a comment.Jan 15 2021, 9:44 AM

It fixes warning similar to the following. This is because it's running ctfconvert on the .c file rather than a .o file.

ctfconvert: rtwn-rtl8821aufw.c: Couldn't read ehdr: Invalid argument

Closed by commit rG94611a838866: Add missing no-ctfconvert to C generation rules (authored by andrew). · Explain WhyJan 15 2021, 9:48 AM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG94611a838866: Add missing no-ctfconvert to C generation rules.

Revision Contents
Changeset List

PathSize
sys/
conf/
98 lines
2 lines
4 lines

Diff 82266

View Options

sys/conf/files

Loading...
View Options

sys/conf/files.amd64

Loading...
View Options

sys/conf/files.arm64

Loading...