Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
sys/x86/x86/busdma_bounce.c | ||
---|---|---|
450 ↗ | (On Diff #82246) | We'll need a check that the alignment isn't too large for malloc_domainset_aligned. |
sys/x86/x86/busdma_bounce.c | ||
---|---|---|
450 ↗ | (On Diff #82246) | There is KASSERT() in malloc_aligned, and I really do not expect small allocations (less than page size) to request large alignment. Another issue is that there is no way to report the alignment limits, except perhaps adding a function to return just the limit. |
sys/kern/kern_malloc.c | ||
---|---|---|
776 | I would add an assertion that the result really is correctly aligned. |
sys/x86/x86/busdma_bounce.c | ||
---|---|---|
437 ↗ | (On Diff #82246) | This comment needs to be updated. |
Comment Actions
I tested D28147.82306.diff on i386 for 8 hours and on amd64 for 47 hours. No problems seen.