Page MenuHomeFreeBSD

isci: use maxphys rather than 128KB to size s/g list
ClosedPublic

Authored by gallatin on Jan 7 2021, 4:26 PM.
Tags
None
Referenced Files
F103000420: D28023.diff
Tue, Nov 19, 4:26 PM
Unknown Object (File)
Oct 8 2024, 10:09 PM
Unknown Object (File)
Oct 8 2024, 3:16 AM
Unknown Object (File)
Oct 5 2024, 5:37 AM
Unknown Object (File)
Oct 5 2024, 3:15 AM
Unknown Object (File)
Oct 4 2024, 6:59 PM
Unknown Object (File)
Oct 3 2024, 8:11 AM
Unknown Object (File)
Oct 3 2024, 8:11 AM
Subscribers

Details

Summary

In the conversion into a tunable, we converted the
size of the s/g list used by the driver to be based
off of a hardcoded size of 128k rather than maxphys,
this caused performance problems for us. Revert this
to use the maxphys tunable.

Note that this constant is used to size dynamically allocated
things, and not static data structs, and is not constrained
by controller hardware limits, so this is safe.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

gallatin created this revision.
This revision is now accepted and ready to land.Jan 7 2021, 4:38 PM

I tested this (at work); it works in our workload (and avoids a severe performance regression).