Page MenuHomeFreeBSD
Differential D27831

rockchip: add audio-related clocks to the CRU driver
ClosedPublic
Actions

Authored by gonzo on Dec 30 2020, 12:28 AM.
Tags
None
Referenced Files
F102943223: D27831.diff
Tue, Nov 19, 1:22 AM
Unknown Object (File)
Oct 5 2024, 11:39 AM
Unknown Object (File)
Oct 2 2024, 9:13 PM
Unknown Object (File)
Oct 2 2024, 8:15 PM
Unknown Object (File)
Oct 2 2024, 12:41 PM
Unknown Object (File)
Oct 1 2024, 10:44 PM
Unknown Object (File)
Oct 1 2024, 10:38 PM
Unknown Object (File)
Oct 1 2024, 10:44 AM
View All 76 Files
Subscribers
andrew
emaste
gbe
imp

Details

Reviewers
manu
mmel
Commits
rGd03fd8ede2c4: rockchip: add audio-related clocks to the CRU driver
Summary
  • Add I2S and CODEC clocks to CRU driver
  • Add support for gate selection to frac clock
  • Add setfreq support to mux clock

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 35798
Build 32687: arc lint + arc unit

Event Timeline

gonzo created this revision.Dec 30 2020, 12:28 AM
Herald added subscribers: emaste, andrew, imp. · View Herald TranscriptDec 30 2020, 12:28 AM
gonzo requested review of this revision.Dec 30 2020, 12:28 AM
Harbormaster completed remote builds in B35773: Diff 81347.Dec 30 2020, 12:28 AM
gbe added a subscriber: gbe.Dec 30 2020, 8:50 AM
manu added inline comments.Dec 30 2020, 9:26 AM
sys/arm64/rockchip/clk/rk_clk_mux.c
166 ↗(On Diff #81347)

We should honor the CLK_SET_ROUND* here.

gonzo added inline comments.Dec 30 2020, 7:12 PM
sys/arm64/rockchip/clk/rk_clk_mux.c
166 ↗(On Diff #81347)

Isn't it handled by line 151? We just pick any parent that can deliver a requested frequency with specified flags.
If we want the best suitable parent according to flags, additional modifications required to clknode_set_freq to get an actual freq achievable by the clock.

gonzo updated this revision to Diff 81381.Dec 30 2020, 7:32 PM
  • Add Allwinner codecs and I2S driver as an example for the framework usage
  • simple-amplifier: make gpio-enable optional
Harbormaster completed remote builds in B35798: Diff 81381.Dec 30 2020, 7:32 PM
gonzo updated this revision to Diff 81383.Dec 30 2020, 7:34 PM

Revert back to the correct diff

Harbormaster completed remote builds in B35800: Diff 81383.Dec 30 2020, 7:34 PM
manu accepted this revision.Dec 31 2020, 10:34 AM
manu added inline comments.
sys/arm64/rockchip/clk/rk_clk_mux.c
166 ↗(On Diff #81347)

Yes you're right, I've miss read this part.

This revision is now accepted and ready to land.Dec 31 2020, 10:34 AM
Closed by commit rGd03fd8ede2c4: rockchip: add audio-related clocks to the CRU driver (authored by gonzo). · Explain WhyJan 4 2021, 1:07 AM
This revision was automatically updated to reflect the committed changes.
gonzo added a commit: rGd03fd8ede2c4: rockchip: add audio-related clocks to the CRU driver.

Revision Contents
Changeset List

PathSize
sys/
arm/
allwinner/
a64/
488 lines
813 lines
417 lines
conf/
7 lines
dev/
sound/
fdt/
72 lines
95 lines
546 lines
127 lines
206 lines

Diff 81381

View Options

sys/arm/allwinner/a64/sun50i_a64_acodec.c

Loading...
View Options

sys/arm/allwinner/aw_i2s.c

Loading...
View Options

sys/arm/allwinner/sun8i_codec.c

Loading...
View Options

sys/conf/files.arm64

Loading...
View Options

sys/dev/sound/fdt/audio_dai.h

Loading...
View Options

sys/dev/sound/fdt/audio_dai_if.m

Loading...
View Options

sys/dev/sound/fdt/audio_soc.c

Loading...
View Options

sys/dev/sound/fdt/dummy_codec.c

Loading...
View Options

sys/dev/sound/fdt/simple_amplifier.c

Loading...