Fix all warnings emitted in `make kernel-toolchain`
ClosedPublic
Actions

Authored by arichardson on Dec 13 2020, 5:21 PM.

Details

Reviewers

imp
emaste
brooks

Commits

rGed8455806e88: Fix all warnings emitted in `make kernel-toolchain`

Summary

With this change and D27598 make kernel-toolchain no longer emits any
warnings for me.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35383
Build 32302: arc lint + arc unit

Event Timeline

arichardson created this revision.Dec 13 2020, 5:21 PM

Herald added a subscriber: andrew. · View Herald TranscriptDec 13 2020, 5:21 PM

Harbormaster completed remote builds in B35383: Diff 80665.Dec 13 2020, 5:21 PM

arichardson requested review of this revision.Dec 13 2020, 5:21 PM

everything but the tools/build/Makefile changes are good. I'm not at all sure that I understand those... This file has become a rather twisty maze, so I've not puzzled all the way through understanding...

tools/build/Makefile
129	Wouldn't you still need the amd64/i386 versions of these as well to build?

arichardson added inline comments.Dec 13 2020, 9:47 PM

tools/build/Makefile
129	Good catch, I got confused about why both existed. Turns out the amd64/i386 headers are simply `#include <x86/elf.h>`, so removing it happened to work, but I'll revert that change and keep installing both to make legacy/include as close to the real include as possible.