Paths

Table of Contentst

Differential D27599

Fix all warnings emitted in `make kernel-toolchain`
ClosedPublic
Actions

Authored by arichardson on Dec 13 2020, 5:21 PM.

Tags

None

Referenced Files

	F102613063: D27599.id81755.diff
	Thu, Nov 14, 7:38 PM

	Unknown Object (File)
	Thu, Oct 31, 9:06 PM

	Unknown Object (File)
	Sun, Oct 20, 7:24 AM

	Unknown Object (File)
	Fri, Oct 18, 10:23 AM

	Unknown Object (File)
	Oct 9 2024, 1:31 AM

	Unknown Object (File)
	Oct 7 2024, 2:46 PM

	Unknown Object (File)
	Oct 4 2024, 12:51 PM

	Unknown Object (File)
	Oct 4 2024, 12:20 PM

Subscribers

Details

Reviewers

imp
emaste
brooks

Commits

rGed8455806e88: Fix all warnings emitted in `make kernel-toolchain`

Summary

With this change and D27598 make kernel-toolchain no longer emits any
warnings for me.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson created this revision.Dec 13 2020, 5:21 PM

Herald added a subscriber: andrew. · View Herald TranscriptDec 13 2020, 5:21 PM

Harbormaster completed remote builds in B35383: Diff 80665.Dec 13 2020, 5:21 PM

arichardson requested review of this revision.Dec 13 2020, 5:21 PM

everything but the tools/build/Makefile changes are good. I'm not at all sure that I understand those... This file has become a rather twisty maze, so I've not puzzled all the way through understanding...

tools/build/Makefile
132	Wouldn't you still need the amd64/i386 versions of these as well to build?

arichardson added inline comments.Dec 13 2020, 9:47 PM

tools/build/Makefile
132	Good catch, I got confused about why both existed. Turns out the amd64/i386 headers are simply `#include <x86/elf.h>`, so removing it happened to work, but I'll revert that change and keep installing both to make legacy/include as close to the real include as possible.

Fix tools/build/Makefile change

Harbormaster completed remote builds in B35414: Diff 80718.Dec 15 2020, 1:12 PM

If there are no objections, I'll commit this together with the MK_WERROR changes (D27601 + D27598) later this week (probably tomorrow afternoon).

LGTM.

This revision is now accepted and ready to land.Jan 6 2021, 2:14 PM

rebase

This revision now requires review to proceed.Jan 6 2021, 5:44 PM

Harbormaster completed remote builds in B35971: Diff 81755.Jan 6 2021, 5:44 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 7 2021, 11:08 AM

Closed by commit rGed8455806e88: Fix all warnings emitted in `make kernel-toolchain` (authored by arichardson). · Explain Why

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rGed8455806e88: Fix all warnings emitted in `make kernel-toolchain`.

Revision Contents
Changeset List

Path

Size

bin/

cat/

6 lines

tools/

build/

6 lines

Diff 81794

bin/cat/cat.c

Loading...

tools/build/Makefile

Loading...