Follow-up to r353959 and r368070: do the same for other architectures.
arm32 already seems to use its own .fnstart/.fnend directives, which
appear to be ARM-specific variants of the same thing. Likewise, MIPS
uses .frame directives.
Differential D27387
Add CFI start/end proc directives to arm64, i386, and ppc cem on Nov 26 2020, 6:27 PM. Authored by Tags None Referenced Files
Details Follow-up to r353959 and r368070: do the same for other architectures. arm32 already seems to use its own .fnstart/.fnend directives, which Tinderbox running.
Diff Detail
Event Timeline
Comment Actions Add a lot of missing END directives. Tinderbox passes on arm64 and i386. Comment Actions Are there any outstanding objections? (I think I've addressed everything raised so far, but please correct me if I am mistaken.) Is there anyone who hasn't reviewed yet, but will have time to review in the next few days? Thanks. Comment Actions Looks good to me. Obviously there might be some non-default build configurations that are missing end() calls, but if so they been be fixed later. Probably best to wait for at least one more review though. Comment Actions I'm fine with it on readthrough, I just hadn't gotten around to the actual tests. If it broke anything in powerpc land, it should be easy to fix. Thanks for tidying up the procedure annotations! Comment Actions Thanks! It compiles (tinderbox, anyway) and shouldn't affect code generation, so I'm cautiously optimistic nothing broke. Please let me know if it broke something and I can help fix it :-). |