linux(4): Emulate Linux SOL_SOCKET:SO_PASSCRED
ClosedPublic
Actions

Authored by cem on Oct 29 2020, 7:57 PM.

Details

Reviewers

markj
trasz

Commits

rS367288: linux(4): Emulate Linux SOL_SOCKET:SO_PASSCRED

Summary

This is required by some major linux applications, such as Chrome and
Firefox. (As well as Electron-using applications, which are essentially
a bundled version of Chrome.)

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 34587
Build 31678: arc lint + arc unit

Event Timeline

cem requested review of this revision.Oct 29 2020, 7:57 PM

cem created this revision.

Harbormaster completed remote builds in B34485: Diff 78924.Oct 29 2020, 7:57 PM

cem added a parent revision: D27011: unix(4): Add SOL_LOCAL:LOCAL_PASSCRED.Oct 29 2020, 7:57 PM

trasz mentioned this in D27011: unix(4): Add SOL_LOCAL:LOCAL_PASSCRED.Oct 29 2020, 8:42 PM

markj accepted this revision.Oct 30 2020, 2:22 PM

markj added inline comments.

sys/compat/linux/linux_socket.c
1573	Make it the first case statement rather than the last, like you did above?

This revision is now accepted and ready to land.Oct 30 2020, 2:22 PM

cem added inline comments.Oct 30 2020, 4:43 PM

sys/compat/linux/linux_socket.c
1573	Will do

Reorder second switch case to match first; no functional change.

This revision now requires review to proceed.Oct 30 2020, 6:33 PM

Harbormaster completed remote builds in B34514: Diff 78975.Oct 30 2020, 6:33 PM

markj accepted this revision.Nov 2 2020, 2:34 PM

This revision is now accepted and ready to land.Nov 2 2020, 2:34 PM

Rebase on parent revision changes.

This revision now requires review to proceed.Nov 2 2020, 9:19 PM

Harbormaster completed remote builds in B34587: Diff 79103.Nov 2 2020, 9:19 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 3 2020, 1:19 AM

Closed by commit rS367288: linux(4): Emulate Linux SOL_SOCKET:SO_PASSCRED (authored by cem). · Explain Why

This revision was automatically updated to reflect the committed changes.

cem added a commit: rS367288: linux(4): Emulate Linux SOL_SOCKET:SO_PASSCRED.

Herald added a subscriber: imp. · View Herald TranscriptNov 3 2020, 1:19 AM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linux/

linux_socket.c

8 lines

Diff 79103

View Options

sys/compat/linux/linux_socket.c

linux(4): Emulate Linux SOL_SOCKET:SO_PASSCREDClosedPublicActions