Bootstrap crunchgen for builds from older trees
ClosedPublic
Actions

Authored by kevans on Sep 16 2020, 5:15 PM.

Details

Reviewers

emaste
arichardson

Commits

rS365887: build: provide a default WARNS for all in-tree builds

Summary

A near-future change will switch the default WARNS to 6 globally, including for the rescue build. This change ensures that we bootstrap crunchgen on older trees so that the output is WARNS-clean.

To complete the change, wipe out the entire rescue objdir if we detect an older rescue.c skeleton -- the crunched_stub_t typedef was added in the WARNS fix, so it should be present in all corrected output from crunchgen.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 33595

Event Timeline

kevans created this revision.Sep 16 2020, 5:15 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 16 2020, 5:15 PM

kevans requested review of this revision.Sep 16 2020, 5:15 PM

Harbormaster completed remote builds in B33595: Diff 77108.Sep 16 2020, 5:15 PM

kevans added a child revision: D26397: build: provide a default WARNS for src builds.Sep 16 2020, 5:16 PM

emaste added inline comments.Sep 16 2020, 5:17 PM

tools/build/depend-cleanup.sh
53	perhaps we should drop the rXXXXXX references form these and put them in the same commit as the change that requires it - svn / git blame will find the right match and really the date is sufficient for the purpose of deciding it's been sufficiently long that we can delete it.

Fine with me, modulo revision comment

This revision is now accepted and ready to land.Sep 16 2020, 5:18 PM

arichardson accepted this revision.Sep 16 2020, 5:20 PM

kevans added inline comments.Sep 16 2020, 11:34 PM

tools/build/depend-cleanup.sh
53	Sure, +1. I'll drop that from this one and merge this change with the next one. I do have some concern because we often historically add these post-mortem, but to be honest we can just tack on the revision in the brief summary part if it really matters. I suspect it doesn't matter, though.