Page MenuHomeFreeBSD

Bootstrap crunchgen for builds from older trees
ClosedPublic

Authored by kevans on Sep 16 2020, 5:15 PM.
Tags
None
Referenced Files
F103040570: D26455.id77190.diff
Wed, Nov 20, 4:04 AM
F103011357: D26455.id77108.diff
Tue, Nov 19, 7:32 PM
F102995363: D26455.diff
Tue, Nov 19, 2:59 PM
Unknown Object (File)
Mon, Nov 18, 6:42 PM
Unknown Object (File)
Mon, Nov 18, 5:50 PM
Unknown Object (File)
Mon, Nov 18, 8:51 AM
Unknown Object (File)
Mon, Nov 18, 8:42 AM
Unknown Object (File)
Mon, Nov 18, 8:26 AM

Details

Summary

A near-future change will switch the default WARNS to 6 globally, including for the rescue build. This change ensures that we bootstrap crunchgen on older trees so that the output is WARNS-clean.

To complete the change, wipe out the entire rescue objdir if we detect an older rescue.c skeleton -- the crunched_stub_t typedef was added in the WARNS fix, so it should be present in all corrected output from crunchgen.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tools/build/depend-cleanup.sh
53 ↗(On Diff #77108)

perhaps we should drop the rXXXXXX references form these and put them in the same commit as the change that requires it - svn / git blame will find the right match and really the date is sufficient for the purpose of deciding it's been sufficiently long that we can delete it.

Fine with me, modulo revision comment

This revision is now accepted and ready to land.Sep 16 2020, 5:18 PM
tools/build/depend-cleanup.sh
53 ↗(On Diff #77108)

Sure, +1. I'll drop that from this one and merge this change with the next one.

I do have some concern because we often historically add these post-mortem, but to be honest we can just tack on the revision in the brief summary part if it really matters. I suspect it doesn't matter, though.