Page MenuHomeFreeBSD

cxgbe: Apply more checks for INET and INET6
ClosedPublic

Authored by np on Sep 5 2020, 12:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 8:11 PM
Unknown Object (File)
Tue, Nov 5, 11:35 PM
Unknown Object (File)
Tue, Nov 5, 7:11 PM
Unknown Object (File)
Oct 7 2024, 5:36 AM
Unknown Object (File)
Oct 2 2024, 5:46 PM
Unknown Object (File)
Oct 2 2024, 1:22 AM
Unknown Object (File)
Oct 1 2024, 4:27 AM
Unknown Object (File)
Oct 1 2024, 1:45 AM
Subscribers

Details

Summary

Currently a NOINET LINT kernels complains about 5 unsued static
functions. Properly hide them behind appropriate #if defined checks
for INET or INET6 to make the kernel compile without warnings.

Reviwed by: ...

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33408
Build 30706: arc lint + arc unit

Event Timeline

bz requested review of this revision.Sep 5 2020, 12:18 AM
This revision is now accepted and ready to land.Oct 19 2020, 5:27 PM

It seems by now there is also needs_inner_tcp_csum() ?
Can you possibly incorporate this in your next driver update and do it yourself @np ?

np edited reviewers, added: bz; removed: np.

okay, I'll take care of this.

This revision now requires review to proceed.Oct 19 2020, 6:39 PM
In D26334#598980, @np wrote:

okay, I'll take care of this.

Great, thanks! :)

This revision was not accepted when it landed; it landed in state Needs Review.May 22 2021, 3:50 AM
This revision was automatically updated to reflect the committed changes.