Page MenuHomeFreeBSD
Differential D26334

cxgbe: Apply more checks for INET and INET6
ClosedPublic
Actions

Authored by np on Sep 5 2020, 12:18 AM.
Tags
None
Referenced Files
F101956377: D26334.diff
Tue, Nov 5, 7:11 PM
Unknown Object (File)
Mon, Oct 7, 5:36 AM
Unknown Object (File)
Oct 2 2024, 5:46 PM
Unknown Object (File)
Oct 2 2024, 1:22 AM
Unknown Object (File)
Oct 1 2024, 4:27 AM
Unknown Object (File)
Oct 1 2024, 1:45 AM
Unknown Object (File)
Sep 30 2024, 1:23 AM
Unknown Object (File)
Sep 27 2024, 3:51 AM
View All 59 Files
Subscribers
ae
imp

Details

Reviewers
bz
Commits
rGfed21efcfce4: cxgbe(4): Fix build warnings with NOINET kernels.
rGffbb373c5a95: cxgbe(4): Fix build warnings with NOINET kernels.
Summary

Currently a NOINET LINT kernels complains about 5 unsued static
functions. Properly hide them behind appropriate #if defined checks
for INET or INET6 to make the kernel compile without warnings.

Reviwed by: ...

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33408
Build 30706: arc lint + arc unit

Event Timeline

bz created this revision.Sep 5 2020, 12:18 AM
Herald added a subscriber: ae. · View Herald TranscriptSep 5 2020, 12:18 AM
bz requested review of this revision.Sep 5 2020, 12:18 AM
Harbormaster completed remote builds in B33408: Diff 76681.Sep 5 2020, 12:18 AM
np accepted this revision.Oct 19 2020, 5:27 PM
This revision is now accepted and ready to land.Oct 19 2020, 5:27 PM
bz added a comment.Oct 19 2020, 6:30 PM

It seems by now there is also needs_inner_tcp_csum() ?
Can you possibly incorporate this in your next driver update and do it yourself @np ?

np commandeered this revision.Oct 19 2020, 6:39 PM
np edited reviewers, added: bz; removed: np.

okay, I'll take care of this.

This revision now requires review to proceed.Oct 19 2020, 6:39 PM
bz added a comment.Oct 19 2020, 7:54 PM
In D26334#598980, @np wrote:

okay, I'll take care of this.

Great, thanks! :)

This revision was not accepted when it landed; it landed in state Needs Review.May 22 2021, 3:50 AM
Closed by commit rGffbb373c5a95: cxgbe(4): Fix build warnings with NOINET kernels. (authored by np). · Explain Why
This revision was automatically updated to reflect the committed changes.
np added a commit: rGffbb373c5a95: cxgbe(4): Fix build warnings with NOINET kernels..
np added a commit: rGfed21efcfce4: cxgbe(4): Fix build warnings with NOINET kernels..Oct 20 2021, 2:11 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 20 2021, 2:11 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
cxgbe/
12 lines

Diff 76681

View Options

sys/dev/cxgbe/t4_sge.c

Loading...