Page MenuHomeFreeBSD
Differential D24787

Link efi programs with -pie rather than -shared
ClosedPublic
Actions

Authored by arichardson on May 9 2020, 5:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 11:41 AM
Unknown Object (File)
Sun, Jan 19, 3:17 PM
Unknown Object (File)
Sat, Jan 18, 10:04 PM
Unknown Object (File)
Fri, Jan 17, 11:39 PM
Unknown Object (File)
Dec 16 2024, 5:27 PM
Unknown Object (File)
Dec 9 2024, 4:32 AM
Unknown Object (File)
Dec 6 2024, 2:01 PM
Unknown Object (File)
Dec 2 2024, 11:00 AM
View All 52 Files
Subscribers
bcran
dab
imp
val_packett.cool

Details

Reviewers
emaste
andrew
jhb
brooks
Commits
rGaa2cddc0d21d: Link efi programs with -pie rather than -shared
rS366644: Link efi programs with -pie rather than -shared
Summary

This was causing build failures in CheriBSD where we were passing -pie
already by default.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31007
Build 28713: arc lint + arc unit

Event Timeline

arichardson created this revision.May 9 2020, 5:55 PM
Herald added a subscriber: bcran. · View Herald TranscriptMay 9 2020, 5:55 PM
arichardson requested review of this revision.May 9 2020, 5:55 PM
Harbormaster completed remote builds in B31007: Diff 71596.May 9 2020, 5:55 PM
val_packett.cool added a subscriber: val_packett.cool.May 25 2020, 12:56 PM

Looks like this breaks aarch64, I got a "Synchronous exception" after the loader detects filesystems. Rebuilding after reverting the change fixed it.

andrew added a comment.Jun 23 2020, 7:34 AM
In D24787#550414, @greg_unrelenting.technology wrote:

Looks like this breaks aarch64, I got a "Synchronous exception" after the loader detects filesystems. Rebuilding after reverting the change fixed it.

Does this fix it? https://github.com/CTSRD-CHERI/cheribsd/commit/ef7b5749427620d6ee1c9834ea6a264f816e99ea

val_packett.cool added a comment.Jun 23 2020, 12:21 PM
In D24787#560671, @andrew wrote:
In D24787#550414, @greg_unrelenting.technology wrote:

Looks like this breaks aarch64, I got a "Synchronous exception" after the loader detects filesystems. Rebuilding after reverting the change fixed it.

Does this fix it? https://github.com/CTSRD-CHERI/cheribsd/commit/ef7b5749427620d6ee1c9834ea6a264f816e99ea

Yes.

arichardson added a comment.Sep 4 2020, 8:43 AM

@andrew okay to commit this?

andrew added a comment.Sep 10 2020, 2:14 PM

I've committed the arm64 fix in rS365578.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 12 2020, 11:27 AM
Closed by commit rS366644: Link efi programs with -pie rather than -shared (authored by arichardson). · Explain Why
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rS366644: Link efi programs with -pie rather than -shared.
Herald added a subscriber: imp. · View Herald TranscriptOct 12 2020, 11:27 AM
kevans added a commit: rGaa2cddc0d21d: Link efi programs with -pie rather than -shared.Oct 8 2021, 4:10 PM
Herald added a subscriber: dab. · View Herald TranscriptOct 8 2021, 4:10 PM

Revision Contents
Changeset List

PathSize
stand/
efi/
boot1/
2 lines
loader/
2 lines

Diff 71596

View Options

stand/efi/boot1/Makefile

Loading...
View Options

stand/efi/loader/Makefile

Loading...