- cryptocheck still passes ok
Details
Details
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 28529 Build 26582: arc lint + arc unit
Event Timeline
Comment Actions
I guess this race doesn't really matter as if you try to use the file before finit() you just get badfileops and finit() itself is "atomic"? If so, I could just leave this as-is unless this approach is preferred.
Comment Actions
No objection, but I believe you're correct about finit() being "atomic." (I mean, it is atomic. But are the fops consumers?)
sys/opencrypto/cryptodev.c | ||
---|---|---|
1516 | Will the compiler complain about storing fd to a uint32_t lvalue? I guess that part has not changed, so no. |