Page MenuHomeFreeBSD

gcc: quiet Wattribute for no_sanitize("address")
ClosedPublic

Authored by rlibby on Dec 19 2019, 9:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 4:45 PM
Unknown Object (File)
Sun, Nov 10, 2:34 AM
Unknown Object (File)
Tue, Nov 5, 2:29 PM
Unknown Object (File)
Sat, Oct 26, 1:38 PM
Unknown Object (File)
Sat, Oct 26, 1:38 PM
Unknown Object (File)
Oct 16 2024, 5:56 AM
Unknown Object (File)
Sep 28 2024, 1:43 AM
Unknown Object (File)
Sep 25 2024, 12:24 AM
Subscribers

Details

Summary

This is an unfortunate instances where the __has_attribute check does
not function usefully. Gcc does have the attribute, but for gcc it only
applies to functions, not variables, and trying to apply it to a
variable generates Wattribute. So far we only apply the attribute to
variables. Only enable the attribute for clang, for now.

Test Plan

make buildkernel
make CROSS_TOOLCHAIN=amd64-gcc9 buildkernel

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28229
Build 26353: arc lint + arc unit

Event Timeline

Works for now. If I have time over the break I’ll take a look at whether gcc could easily be extended to apply this attribute to variables where it makes sense.

This revision is now accepted and ready to land.Dec 19 2019, 4:29 PM
This revision was automatically updated to reflect the committed changes.