Page MenuHomeFreeBSD
Differential D21346

makefs: share fat.h between kernel msdosfs and makefs
ClosedPublic
Actions

Authored by emaste on Aug 20 2019, 7:13 PM.
Tags
None
Referenced Files
F115989108: D21346.id61071.diff
Thu, May 1, 6:52 AM
F115948448: D21346.diff
Wed, Apr 30, 6:36 PM
Unknown Object (File)
Fri, Apr 18, 4:04 AM
Unknown Object (File)
Tue, Apr 15, 3:51 AM
Unknown Object (File)
Tue, Apr 15, 3:49 AM
Unknown Object (File)
Tue, Apr 15, 3:40 AM
Unknown Object (File)
Tue, Apr 15, 3:40 AM
Unknown Object (File)
Tue, Apr 15, 3:39 AM
View All Files
Subscribers
None

Details

Reviewers
cem
imp
Commits
rS351321: makefs: share fat.h between kernel msdosfs and makefs

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste created this revision.Aug 20 2019, 7:13 PM
emaste added inline comments.
sys/fs/msdosfs/fat.h
99–104

NetBSD doesn't have these declarations; check what they do

usr.sbin/makefs/msdos/msdosfs_conv.c
65

just remove this

emaste updated this revision to Diff 61059.Aug 20 2019, 7:25 PM

shuffle includes to avoid struct declarations

emaste mentioned this in D11197: msdosfs: expose and hide definitions/functions for makefs FAT fs support.Aug 20 2019, 7:38 PM
cem accepted this revision.Aug 20 2019, 10:05 PM
This revision is now accepted and ready to land.Aug 20 2019, 10:05 PM
imp accepted this revision.Aug 20 2019, 10:25 PM
Closed by commit rS351321: makefs: share fat.h between kernel msdosfs and makefs (authored by emaste). · Explain WhyAug 21 2019, 2:21 AM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rS351321: makefs: share fat.h between kernel msdosfs and makefs.

Revision Contents
Changeset List

PathSize
sys/
fs/
msdosfs/
10 lines
usr.sbin/
makefs/
msdos/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines

Diff 61058

View Options

sys/fs/msdosfs/fat.h

Loading...
View Options

usr.sbin/makefs/msdos/Makefile.inc

Loading...
View Options

usr.sbin/makefs/msdos/fat.h

Loading...
View Options

usr.sbin/makefs/msdos/msdosfs_conv.c

Loading...
View Options

usr.sbin/makefs/msdos/msdosfs_denode.c

Loading...
View Options

usr.sbin/makefs/msdos/msdosfs_fat.c

Loading...
View Options

usr.sbin/makefs/msdos/msdosfs_lookup.c

Loading...
View Options

usr.sbin/makefs/msdos/msdosfs_vfsops.c

Loading...
View Options

usr.sbin/makefs/msdos/msdosfs_vnops.c

Loading...