Add set ToS test for ipfw and pf
ClosedPublic
Actions

Authored by ahsanb on Aug 17 2019, 2:31 PM.

Details

Reviewers

kp
thj

Commits

rGcacf2d4beb4e: netpfil tests: Add the set ToS test for ipfw and pf
rS351248: netpfil tests: Add the set ToS test for ipfw and pf

Summary

Add the set ToS test for ipfw and pf. This test tests the following:

The firewall is able to set the tos bits
The firewall is able to set the DSCP bits when EN bits is already set and the EN bits remains unchanged.
The firewall is able to drop the packets based on ToS value

Note: This diff must be applied after applying D21276

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

ahsanb created this revision.Aug 17 2019, 2:31 PM

ahsanb edited the summary of this revision. (Show Details)

ahsanb mentioned this in D21307: Add too many fragments test for pf, ipfw and ipf.Aug 17 2019, 5:46 PM

thj added inline comments.Aug 18 2019, 6:05 PM

tests/sys/netpfil/common/tos.sh
64	Can you wrap this comment and the two below so that there lines don't wrap? This one might be fine, but the one below is probably too long

wrap the comments

This revision was not accepted when it landed; it landed in state Needs Review.Aug 20 2019, 2:31 PM

Closed by commit rS351248: netpfil tests: Add the set ToS test for ipfw and pf (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rS351248: netpfil tests: Add the set ToS test for ipfw and pf.

Herald added a subscriber: imp. · View Herald TranscriptAug 20 2019, 2:31 PM

kp added a commit: rGcacf2d4beb4e: netpfil tests: Add the set ToS test for ipfw and pf.Sep 14 2021, 8:03 PM

Herald added a subscriber: melifaro. · View Herald TranscriptSep 14 2021, 8:03 PM

Revision Contents
Changeset List

Path

Size

tests/

sys/

netpfil/

common/

Makefile

3 lines

tos.sh

115 lines

Diff 60943

View Options

tests/sys/netpfil/common/Makefile