Page MenuHomeFreeBSD
Differential D20272

if_mxge to update zlib version 1.0.4 to 1.2.11.
ClosedPublic
Actions

Authored by ota_j.email.ne.jp on May 16 2019, 4:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 22, 11:38 AM
Unknown Object (File)
Tue, Oct 22, 11:38 AM
Unknown Object (File)
Tue, Oct 22, 11:38 AM
Unknown Object (File)
Tue, Oct 22, 11:37 AM
Unknown Object (File)
Tue, Oct 22, 12:49 AM
Unknown Object (File)
Tue, Oct 22, 12:37 AM
Unknown Object (File)
Sat, Oct 19, 11:23 PM
Unknown Object (File)
Oct 2 2024, 4:58 PM
View All Files
Subscribers
imp
Contributor Reviews (src)

Details

Reviewers
jmg
delphij
kib
Group Reviewers
manpages
Commits
rS350554: if_mxge: update zlib version 1.0.4 to 1.2.11.
Summary

Update if_mxge to use newer zlib version.
Also use zcalloc/zfree from ZLIB namespace.

This change depends on D20193 and D19706.
Let's figure out the best way to handle Z_SOLO and zalloc/zfree handling with D20271, first.

Test Plan

TBD

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24254
Build 23086: arc lint + arc unit

Event Timeline

ota_j.email.ne.jp created this revision.May 16 2019, 4:34 AM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptMay 16 2019, 4:34 AM
Harbormaster completed remote builds in B24254: Diff 57434.May 16 2019, 4:34 AM
Harbormaster completed remote builds in B24254: Diff 57434.
ota_j.email.ne.jp added reviewers: jmg, delphij, kib.May 16 2019, 4:35 AM
delphij requested changes to this revision.Jul 31 2019, 5:42 PM
delphij added inline comments.
sys/dev/mxge/if_mxge.c
727

I think inflateInit() still expects zfree be set?

This revision now requires changes to proceed.Jul 31 2019, 5:42 PM
ota_j.email.ne.jp updated this revision to Diff 60379.Aug 2 2019, 2:26 AM

Given we added -DZ_SOLO to zlib, pass zfree function explicitly.

Herald added a reviewer: manpages. · View Herald TranscriptAug 2 2019, 2:26 AM
Harbormaster completed remote builds in B25634: Diff 60379.Aug 2 2019, 2:26 AM
ota_j.email.ne.jp added inline comments.Aug 2 2019, 2:28 AM
sys/dev/mxge/if_mxge.c
149

We have had zlib dependency here.

ota_j.email.ne.jp edited the summary of this revision. (Show Details)Aug 2 2019, 3:46 AM
delphij accepted this revision.Aug 2 2019, 4:16 AM

Will commit after a tinderbox build.

This revision is now accepted and ready to land.Aug 2 2019, 4:16 AM
Closed by commit rS350554: if_mxge: update zlib version 1.0.4 to 1.2.11. (authored by delphij). · Explain WhyAug 3 2019, 3:36 AM
This revision was automatically updated to reflect the committed changes.
delphij added a commit: rS350554: if_mxge: update zlib version 1.0.4 to 1.2.11..

Revision Contents
Changeset List

PathSize
sys/
conf/
3 lines
dev/
mxge/
22 lines
modules/
mxge/
mxge/
2 lines

Diff 57434

View Options

sys/conf/files

Loading...
View Options

sys/dev/mxge/if_mxge.c

Loading...
View Options

sys/modules/mxge/mxge/Makefile

Loading...