bhyve: provide basic descriptions for VMX exit reason

[yuripv]

Summary

Provide basic descriptions for VMX exit reason (from "Intel® 64 and IA-32 Architectures Software Developer’s Manual Volume 3"). Add the document to SEE ALSO in bhyve.8 (and pet manlint here a bit).

It makes it a bit easier to understand the reason of exit, e.g.:

vm exit[0]
        reason          VMX
        rip             0x000000000000fff0
        inst_length     3
        status          0
        exit_reason     48 (EPT violation)
        qualification   0x0000000000000184
        inst_type               0
        inst_error              0
Abort trap

[0mp]

The manual page update seems fine from the mdoc perspective.

[yuripv]

copy/paste error

[kib]

usr.sbin/bhyve/bhyverun.c

94

const char * const ? If it passes over other places.

95

Use designated initializers, even if the indexes do not have symbolic names. Put each initialization element on its own line.

604

I would create a static function which does the calculation of the string by number.

[yuripv]

Address comments.

[yuripv]

usr.sbin/bhyve/bhyverun.c

95

Done, I hope that including <amd64/vmm/intel/vmcs.h> is OK here.

[kib]

usr.sbin/bhyve/bhyverun.c

95

This header is not installed, so bhyve(8) definitely requires the build from the full sources. I remember that it was the case already due to vmm_instructions_emul.c.

587

Blank line is needed after '{' if no locals are defined.

590

This blank line is excessive.

[yuripv]

style fixes

[yuripv]

Can I proceed with kib being the reviewer for this, or bhyve group will take a look?

[rgrimes]

The bhyve group hat was requested by Peter Grehan for "Maintainer" approval and awareness of bhyve bits, as far as I can see this review does not touch any bits that need bhyve maintainer approval, so you can commit with out an accept from them.

I am accepting this as me personally, I am not a person who can wear hat bhyve maintainer.

[jhb]

usr.sbin/bhyve/bhyve.8

503

I think the doc folks would want all of the formatting changes to this file be done as a separate commit from the actual content change. I think adding the reference to the Intel SDM manual is the only content change to this file?

[yuripv]

usr.sbin/bhyve/bhyve.8

503

Yes, the only content change is added reference. Formatting changes are mostly pointed out by mandoc lint, and seem to be formally accepted by manpages (@0mp).

[araujo]

Hi @yuripv , is there anything pending for this patch to be committed?

[yuripv]

In D17531#378698, @araujo wrote:

Hi @yuripv , is there anything pending for this patch to be committed?

Sorry for the delay, submitted to mentor for approval.