newvers.sh: fix git false positive -dirty tag

[emaste]

Summary

Assuming that any output from git diff-index --name-only implies changes in the working tree results in false positives: files with metadata, but not content, changes are also listed.

Check that content differences exist before adding the -dirty tag to the git hash.

PR: 229230

[emaste]

sys/conf/newvers.sh

93 ↗

(On Diff #44311)

This will be $git_cmd not git.

[emaste]

Hrm, this only works if git diff is run at the top level dir; needs further investigation.

[emaste]

cd to the VCS topdir before invoking git diff

[kib]

Can you use --shortstat instead of parsing sha's ?

[emaste]

In D15968#376629, @kib wrote:

Can you use --shortstat instead of parsing sha's ?

No, the user-facing commands have the false positive problem identified in the comment, and trying to use plain git diff has performance concerns.

[markj]

sys/conf/newvers.sh

80 ↗

(On Diff #44314)

Declare locals?

83 ↗

(On Diff #44314)

"latter"

94 ↗

(On Diff #44314)

IMO it would be a bit nicer to cache foo=$(realpath "$VCSTOP") (to ensure that it's an absolute path), and then git diff "${foo}/${file}". Then you don't need the subshell.

[emaste]

markj feedback

[markj]

sys/conf/newvers.sh

80 ↗

(On Diff #44314)

There's also smode, dmode, ssha, dsha, status, file.

[emaste]

sys/conf/newvers.sh

80 ↗

(On Diff #44314)

The while loop has an implicit subshell and the loop variables themselves aren't visible outside so I think they're not needed.