Add workaround for broken PSCI implementation.
Needs ReviewPublic
Actions

Authored by mmel on Jan 11 2018, 3:46 PM.

Details

Reviewers

andrew
manu

Summary

By specification, the PSCI CPU_ON command should pass context_id argument
in X0 register for newly started core. But it seems that at least U-Boot
based PSCI implementation corrupt it.
Use the cpu_mpidrs table for validation of X0 (context_id) value and if
is not valid, use it for searching of correct context_id.

MFC after: 1 month

Test Plan

r359280 removed the need to access the cpu_mpidr table from the assembler (to determine right secondary stack) . Move the check into mp_machdep.c.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

mmel created this revision.Jan 11 2018, 3:46 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptJan 11 2018, 3:46 PM

mmel added a parent revision: D13863: Simplify and cleanup startup code for secondary cores..Jan 11 2018, 3:46 PM

Does this need to live in asm? If we don't trust the value passed we should just stop using it, but this would be easier to follow if it was moved to init_secondary.

mmel mentioned this in D13863: Simplify and cleanup startup code for secondary cores..Jan 12 2018, 7:09 AM

I agree but, unfortunately, yes. The context_id is used for selecting right stack. See line 270 in new file.

mmel updated this revision to Diff 73102.Jun 14 2020, 9:30 AM

mmel edited the test plan for this revision. (Show Details)

Herald added a reviewer: manu. · View Herald TranscriptJun 14 2020, 9:30 AM