textproc/pootle revival

[rene]

Summary

@wblock asked me to revive pootle. Well, here it is -- it needs a bit of work though.

Pootle depends on an older version of django. We have this version in ports, but we don't have a way to build django packages like www/py-django-tastypie against anything other than the default django version. As a result, a conflict is created because these django modules try to bring in the wrong version of django.

Also we're missing a port entirely for django-voting, but if we can resolve these issues pootle can be revived!

[koobs]

textproc/pootle/Makefile

7

Use CHEESESHOP

• See: https://pypi.python.org/pypi/Pootle/2.5.1.1

12

Remove 'Pootle is a'

13–14

Missing LICENSE / LICENSE_FILE

14–15

These are all RUN_DEPENDS, not BUILD_DEPENDS. Most Python packages are the same

17

Unnecessary with above change

18–19

What are the actual conflicts here?

33

autoplist?

33–34

Not necessary with AUTOPLIST

35–36

Suggest dedicated user/group IN UID/GID

42–43

Is this necessary with the shared desc in Mk/bsd.options.desc.mk ?

42–43

Is this necessary with the shared desc in Mk/bsd.options.desc.mk ?

43

• Does pootle support SQLITE? If so, this is a better OPTIONS_DEFAULT and matches what django does.
• Do the others 'need' to be default?

43

s/+=/=

[xmj]

textproc/pootle/Makefile

14–15

In addition to that (already mentioned on IRC),
the new version that's currently in RC status will work with Django 1.6 (officially),
and Django 1.7 (unofficially, but confirmed with the developers).

If you bind it to 1.6 weirdness will ensue, due to some of the RUN_DEPENDENCIES mentioned here pulling in Django 1.7.

So, for better or worse, I'd recommend binding it to Django 1.7 directly.

[wblock]

The PCBSD folks just updated to the newer version of Pootle and might have suggestions for the port.

textproc/pootle/files/pootle.in

16

Shouldn't that still be %%POOTLELOGDIR%%?

[feld]

textproc/pootle/Makefile

18–19

Not sure. Leftover from old port.

43

SQLITE? Yes. But they do not want you to use SQLITE in production.

As for the others -- I don't like forcing people to build from ports to use their favorite database if it doesn't pull in very many dependencies.

textproc/pootle/files/pootle.in

16

I was working towards killing %%POOTLELOGDIR%% because to me it seems like something you should be configuring in rc.conf not in the port Makefile.

[rene]

pootle 2.5.3 is out, I'll see how that works out.

[rene]

I should probably merge my version into here, a preview of it is available at https://people.freebsd.org/~rene/pootle-2.1.5.3.tar.xz

[rene]

Taking this revision so that phabricator lets me attach a new diff to it.

[rene]

• Update dependencies
• Remove pkg-plist in favor of autoplist
• Make it run (but config is probably wrong)

[rene]

• Added textproc/py-diff-match-patch as RUN_DEPENDS
• Use USERS and GROUPS
• Clean up Makefile

[rene]

textproc/pootle/Makefile

42–43

Yes, MEMCACHED is not in bsd.options.desc.mk (yet)

[rene]

Use SVN option instead of homegrown SUBVERSION, the former has a description already.

[feld]

Good work rene! I'll try to comb it over soon.

[kmoore]

This looks pretty cool. What bugs do the patches fix specifically? We've been using Pootle just installed from pip and its normal methods, seems to work fine here.

[rene]

In D1234#61288, @kmoore wrote:

This looks pretty cool. What bugs do the patches fix specifically? We've been using Pootle just installed from pip and its normal methods, seems to work fine here.

Oops, only saw this now...

The patches are just the usual "make it work" patches, some interfaces were no longer available (e.g. sha_constructor -> hashlib.sha1).

The patch regarding transaction.commit_on_success is taken from https://github.com/evernote/pootle/commit/8f64489 . https://codereview.stackexchange.com/questions/53751/replacement-for-commit-on-success might also be interesting to read.

[rene]

textproc/pootle/Makefile

14–15

The current port does not depend on Django directly, only on
django-taggit>0.10, django-assets>=0.8, and django-voting>=0.1

14–15

textproc/py-sphinx seems to be used both as a build and run dependency [1], what would be best?

[1] https://www.freshports.org/textproc/py-sphinx/

textproc/pootle/files/pootle.in

16

I removed %%POOTLELOGDIR%% in my working copy. If needed we can add it back.

[rene]

textproc/pootle/Makefile

14–15

I left out textproc/py-sphinx for now, it builds fine without.

43

Currently the port only has support for MySQL and PostgreSQL, so the comment is irrelevant.

[bcr]

I can live with MySQL and especially PostgreSQL as the database backend. That should suffice for the port, I think.