Page MenuHomeFreeBSD
Differential D1234

textproc/pootle revival
ClosedPublic
Actions

Authored by rene on Nov 26 2014, 5:38 PM.
Tags
None
Referenced Files
F102763182: D1234.id2557.diff
Sat, Nov 16, 8:21 PM
Unknown Object (File)
Thu, Nov 7, 10:36 AM
Unknown Object (File)
Wed, Nov 6, 5:20 PM
Unknown Object (File)
Wed, Nov 6, 2:36 AM
Unknown Object (File)
Sun, Nov 3, 7:55 PM
Unknown Object (File)
Sun, Nov 3, 4:28 AM
Unknown Object (File)
Wed, Oct 30, 2:21 PM
Unknown Object (File)
Mon, Oct 28, 10:08 PM
View All Files
Subscribers
bcr
feld
kmoore
koobs
lwhsu
rene
wblock
xmj

Details

Reviewers
koobs
Commits
rP398437: Resurrect textproc/pootle and update it to 2.5.1.3
Summary

@wblock asked me to revive pootle. Well, here it is -- it needs a bit of work though.

Pootle depends on an older version of django. We have this version in ports, but we don't have a way to build django packages like www/py-django-tastypie against anything other than the default django version. As a result, a conflict is created because these django modules try to bring in the wrong version of django.

Also we're missing a port entirely for django-voting, but if we can resolve these issues pootle can be revived!

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

feld updated this revision to Diff 2557.Nov 26 2014, 5:38 PM
feld retitled this revision from to textproc/pootle revival.
feld updated this object.
feld edited the test plan for this revision. (Show Details)
feld set the repository for this revision to rP FreeBSD ports repository.
feld added subscribers: koobs, xmj, wblock.
koobs requested changes to this revision.Nov 27 2014, 1:32 AM
koobs added a reviewer: koobs.
koobs added inline comments.
textproc/pootle/Makefile
7 ↗(On Diff #2557)

Use CHEESESHOP

11 ↗(On Diff #2557)

Remove 'Pootle is a'

12 ↗(On Diff #2557)

Missing LICENSE / LICENSE_FILE

13 ↗(On Diff #2557)

These are all RUN_DEPENDS, not BUILD_DEPENDS. Most Python packages are the same

23 ↗(On Diff #2557)

Unnecessary with above change

25 ↗(On Diff #2557)

What are the actual conflicts here?

29 ↗(On Diff #2557)

autoplist?

30 ↗(On Diff #2557)

Not necessary with AUTOPLIST

32 ↗(On Diff #2557)

Suggest dedicated user/group IN UID/GID

44 ↗(On Diff #2557)
  • Does pootle support SQLITE? If so, this is a better OPTIONS_DEFAULT and matches what django does.
  • Do the others 'need' to be default?
45 ↗(On Diff #2557)

Is this necessary with the shared desc in Mk/bsd.options.desc.mk ?

46 ↗(On Diff #2557)

Is this necessary with the shared desc in Mk/bsd.options.desc.mk ?

59 ↗(On Diff #2557)

s/+=/=

This revision now requires changes to proceed.Nov 27 2014, 1:32 AM
xmj added inline comments.Nov 27 2014, 9:44 AM
textproc/pootle/Makefile
13 ↗(On Diff #2557)

In addition to that (already mentioned on IRC),
the new version that's currently in RC status will work with Django 1.6 (officially),
and Django 1.7 (unofficially, but confirmed with the developers).

If you bind it to 1.6 weirdness will ensue, due to some of the RUN_DEPENDENCIES mentioned here pulling in Django 1.7.

So, for better or worse, I'd recommend binding it to Django 1.7 directly.

wblock added a comment.Nov 27 2014, 3:21 PM

The PCBSD folks just updated to the newer version of Pootle and might have suggestions for the port.

textproc/pootle/files/pootle.in
16 ↗(On Diff #2557)

Shouldn't that still be %%POOTLELOGDIR%%?

feld added inline comments.Nov 27 2014, 3:35 PM
textproc/pootle/Makefile
25 ↗(On Diff #2557)

Not sure. Leftover from old port.

44 ↗(On Diff #2557)

SQLITE? Yes. But they do not want you to use SQLITE in production.

As for the others -- I don't like forcing people to build from ports to use their favorite database if it doesn't pull in very many dependencies.

textproc/pootle/files/pootle.in
16 ↗(On Diff #2557)

I was working towards killing %%POOTLELOGDIR%% because to me it seems like something you should be configuring in rc.conf not in the port Makefile.

rene added a subscriber: rene.Feb 14 2015, 4:03 PM
rene added a comment.Jun 10 2015, 7:25 PM

pootle 2.5.3 is out, I'll see how that works out.

lwhsu added a subscriber: lwhsu.Jun 11 2015, 1:11 PM
rene mentioned this in D2835: [new port] : textproc/py-diff-match-patch.Jun 15 2015, 10:32 PM
rene added a parent revision: D2835: [new port] : textproc/py-diff-match-patch.Jun 22 2015, 7:13 PM
rene added a parent revision: D2928: www/py-django-assets : relax requirement for webassets.Jun 27 2015, 8:31 PM
rene added a parent revision: D2932: www/py-django-taggit : Update to 0.15.0.Jun 28 2015, 2:40 PM
rene added a comment.Jun 28 2015, 5:31 PM

I should probably merge my version into here, a preview of it is available at https://people.freebsd.org/~rene/pootle-2.1.5.3.tar.xz

rene edited edge metadata.Jun 29 2015, 8:46 PM
rene set the repository for this revision to rP FreeBSD ports repository.
rene commandeered this revision.Jun 29 2015, 10:02 PM
rene added a reviewer: feld.

Taking this revision so that phabricator lets me attach a new diff to it.

rene updated this revision to Diff 6560.Jun 29 2015, 10:04 PM
rene edited edge metadata.
  • Update dependencies
  • Remove pkg-plist in favor of autoplist
  • Make it run (but config is probably wrong)
rene marked 6 inline comments as done.Jul 3 2015, 8:14 PM
rene updated this revision to Diff 6872.Jul 12 2015, 1:33 PM
rene edited edge metadata.
  • Added textproc/py-diff-match-patch as RUN_DEPENDS
  • Use USERS and GROUPS
  • Clean up Makefile
rene marked 5 inline comments as done.Jul 12 2015, 1:37 PM
rene added inline comments.
textproc/pootle/Makefile
42–43 ↗(On Diff #6872)

Yes, MEMCACHED is not in bsd.options.desc.mk (yet)

rene updated this revision to Diff 6873.Jul 12 2015, 1:38 PM
rene marked an inline comment as done.

Use SVN option instead of homegrown SUBVERSION, the former has a description already.

feld resigned from this revision.Jul 12 2015, 10:24 PM
feld removed a reviewer: feld.
rene marked an inline comment as done.Jul 13 2015, 5:32 AM
feld added a subscriber: feld.Jul 14 2015, 11:39 PM

Good work rene! I'll try to comb it over soon.

bcr added a subscriber: bcr.Jul 15 2015, 7:10 AM
kmoore added a subscriber: kmoore.Jul 15 2015, 4:03 PM

This looks pretty cool. What bugs do the patches fix specifically? We've been using Pootle just installed from pip and its normal methods, seems to work fine here.

rene added a comment.Jul 23 2015, 5:31 PM
In D1234#61288, @kmoore wrote:

This looks pretty cool. What bugs do the patches fix specifically? We've been using Pootle just installed from pip and its normal methods, seems to work fine here.

Oops, only saw this now...

The patches are just the usual "make it work" patches, some interfaces were no longer available (e.g. sha_constructor -> hashlib.sha1).

The patch regarding transaction.commit_on_success is taken from https://github.com/evernote/pootle/commit/8f64489 . https://codereview.stackexchange.com/questions/53751/replacement-for-commit-on-success might also be interesting to read.

rene marked 4 inline comments as done.Oct 2 2015, 9:48 AM
rene added inline comments.
textproc/pootle/Makefile
14–15 ↗(On Diff #6873)

The current port does not depend on Django directly, only on
django-taggit>0.10, django-assets>=0.8, and django-voting>=0.1

14–15 ↗(On Diff #6873)

textproc/py-sphinx seems to be used both as a build and run dependency [1], what would be best?

[1] https://www.freshports.org/textproc/py-sphinx/

textproc/pootle/files/pootle.in
16 ↗(On Diff #6873)

I removed %%POOTLELOGDIR%% in my working copy. If needed we can add it back.

rene marked 8 inline comments as done.Oct 2 2015, 1:08 PM
rene added inline comments.
textproc/pootle/Makefile
14–15 ↗(On Diff #6873)

I left out textproc/py-sphinx for now, it builds fine without.

43 ↗(On Diff #6873)

Currently the port only has support for MySQL and PostgreSQL, so the comment is irrelevant.

bcr added a comment.Oct 2 2015, 1:13 PM

I can live with MySQL and especially PostgreSQL as the database backend. That should suffice for the port, I think.

Closed by commit rP398437: Resurrect textproc/pootle and update it to 2.5.1.3 (authored by rene). · Explain WhyOct 2 2015, 3:18 PM
This revision was automatically updated to reflect the committed changes.
rene marked an inline comment as done.
imp mentioned this in D39992: git-arc: Add -c flag to patch to commit the change.May 7 2023, 5:34 AM
imp mentioned this in rG787cb30d20ac: git-arc: Add -c flag to patch to commit the change.Jan 15 2024, 2:25 AM

Revision Contents
Changeset List

Diff 9058

View Options

head/GIDs

Loading...
View Options

head/UIDs

Loading...
View Options

head/textproc/Makefile

Loading...
View Options

head/textproc/pootle/Makefile

Loading...
View Options

head/textproc/pootle/distinfo

Loading...
View Options

head/textproc/pootle/files/patch-pootle_apps_djblets_util_fields.py

Loading...
View Options

head/textproc/pootle/files/patch-pootle_apps_pootle__app_views_admin_dashboard.py

Loading...
View Options

head/textproc/pootle/files/patch-pootle_apps_pootle__misc_forms.py

Loading...
View Options

head/textproc/pootle/files/patch-pootle_apps_pootle__misc_util.py

Loading...
View Options

head/textproc/pootle/files/patch-pootle_apps_pootle__store_models.py

Loading...
View Options

head/textproc/pootle/files/patch-pootle_apps_pootle__store_views.py

Loading...
View Options

head/textproc/pootle/files/patch-pootle_apps_pootle__terminology_views.py

Loading...
View Options

head/textproc/pootle/files/patch-pootle_apps_registration_models.py

Loading...
View Options

head/textproc/pootle/files/patch-pootle_middleware_captcha.py

Loading...
View Options

head/textproc/pootle/files/patch-pootle_middleware_errorpages.py

Loading...
View Options

head/textproc/pootle/files/pootle.in

Loading...
View Options

head/textproc/pootle/pkg-descr

Loading...