Differential D11806

Enable IPSEC_SUPPORT.
AbandonedPublic
Actions

Authored by delphij on Aug 1 2017, 3:13 PM.

Tags

None

Referenced Files

	F102843172: D11806.diff
	Sun, Nov 17, 9:38 PM

	Unknown Object (File)
	Wed, Nov 6, 2:26 PM

	Unknown Object (File)
	Wed, Oct 23, 11:17 AM

	Unknown Object (File)
	Wed, Oct 23, 9:27 AM

	Unknown Object (File)
	Oct 16 2024, 7:38 PM

	Unknown Object (File)
	Oct 16 2024, 7:38 PM

	Unknown Object (File)
	Oct 16 2024, 7:38 PM

	Unknown Object (File)
	Oct 16 2024, 7:16 PM

View All 61 Files

Subscribers

eugen_grosbein.net

Details

Reviewers

ae
gnn
eugen_grosbein.net
glebius
manu

Group Reviewers

Commits

rS323087: Take options IPSEC out of GENERIC

Summary

Enable IPSEC_SUPPORT.

Test Plan

build and load tcpmd5.ko

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10784
Build 11179: arc lint + arc unit

Event Timeline

delphij created this revision.Aug 1 2017, 3:13 PM

Herald added subscribers: jhibbits, emaste, andrew, imp. · View Herald TranscriptAug 1 2017, 3:13 PM

Harbormaster completed remote builds in B10784: Diff 31429.Aug 1 2017, 3:13 PM

What it we replace IPSEC with IPSEC_SUPPORT?
Then the profit will have those

who doesn't use IPsec will not rebuild the kernel to avoid overhead
who want to use IPsec, they can do kldload ipsec
who want to use TCP-MD5, they can do kldload tcpmd5

ae added reviewers: gnn, network.Aug 1 2017, 3:53 PM

eugen_grosbein.net added a subscriber: eugen_grosbein.net.Aug 9 2017, 2:29 PM

eugen_grosbein.net accepted this revision.Aug 9 2017, 3:04 PM

This revision is now accepted and ready to land.Aug 9 2017, 3:04 PM

glebius accepted this revision.Aug 9 2017, 4:13 PM

Sorry for clicking wrong button. I'm seconding ae@: IPSEC_SUPPORT should remain, but IPSEC should be removed. The ipsec.ko and tcpmd5.ko should be loadable, not statically compiled in.

This revision now requires changes to proceed.Aug 9 2017, 4:54 PM

I'm seconding ae@: IPSEC_SUPPORT should remain, but IPSEC should be removed. The ipsec.ko and tcpmd5.ko should be loadable, not statically compiled in.

I'd be fine with both variants.

Sure.

Closed by commit rS323087: Take options IPSEC out of GENERIC (authored by jpaetzel). · Explain WhySep 1 2017, 3:55 PM

This revision was automatically updated to reflect the committed changes.

jpaetzel mentioned this in rS323087: Take options IPSEC out of GENERIC.

I reverted this commit. We need more consensus before continuing.

Can this be closed? ipsec got removed in D20163

Herald added a reviewer: manu. · View Herald TranscriptDec 9 2021, 9:47 PM

Superseded by D20163

Revision Contents
Changeset List

Path

Size

sys/

amd64/

conf/

1 line

arm/

conf/

1 line

arm64/

conf/

1 line

i386/

conf/

1 line

mips/

conf/

1 line

1 line

powerpc/

conf/

1 line

riscv/

conf/

1 line

sparc64/

conf/

1 line

Diff 31429

sys/amd64/conf/GENERIC

Loading...

sys/arm/conf/std.armv6

Loading...

sys/arm64/conf/GENERIC

Loading...

sys/i386/conf/GENERIC

Loading...

sys/mips/conf/ERL

Loading...

sys/mips/conf/std.XLP

Loading...

sys/powerpc/conf/GENERIC

Loading...

sys/riscv/conf/GENERIC

Loading...

sys/sparc64/conf/GENERIC

Loading...