Slight cleanup in open_binary_fd.

[delphij]

Summary

In open_binary_fd: when using buffer size for strl* and snprintf,
always use >= instead of > to avoid truncation.

[kib]

libexec/rtld-elf/rtld.c

5317

Compare the size of ld.so before and after your patch is applied.

[delphij]

libexec/rtld-elf/rtld.c

5317

I haven't considered it (and thanks for pointing out). I'll update this one to a smaller scope.

[delphij]

In open_binary_fd: when using buffer size for strl* and snprintf,
always use >= instead of > to avoid truncation.

[kib]

The issue with stdio in rtld is not limited to the bloat. Locale stuff that gets pulled in causes runtime breakage for rtld. One of the reason is that it uses TLS.

Overall, rtld is not a C hosted environment, which is obvious in hindsight.