HomeFreeBSD

tcp: improve consistency of SYN-cache handling

Description

tcp: improve consistency of SYN-cache handling

Originally, a SYN-cache entry was always allocated and later freed,
when not needed anymore. Then the allocation was avoided, when no
SYN-cache entry was needed, and a copy on the stack was used.
But the logic regarding freeing was not updated.
This patch doesn't re-check conditions (which may have changed) when
deciding to insert or free the entry, but uses the result of
the earlier check.
This simplifies the code and improves also consistency.

Reviewed by: glebius
MFC after: 1 week
Sponsored by: Netflix, Inc.
Differential Revision: https://reviews.freebsd.org/D46410

Details

Provenance
tuexenAuthored on Aug 22 2024, 8:17 PM
Reviewer
glebius
Differential Revision
D46410: tcp: improve consistency of SYN-cache handling
Parents
rG8afae0caf4c4: riscv: Add machine/ifunc.h corresponding to rtld-elf's resolver interface
Branches
Unknown
Tags
Unknown