HomeFreeBSD

swap_pager: Fix a race in swap_pager_swapoff_object()

Description

swap_pager: Fix a race in swap_pager_swapoff_object()

When we disable swapping to a device, we scan the full VM object list
looking for objects with swap trie nodes that reference the device in
question. The pages corresponding to those nodes are paged in.

While paging in, we drop the VM object lock. Moreover, we do not hold a
reference for the object; swap_pager_swapoff_object() merely bumps the
paging-in-progress counter. vm_object_terminate() waits for this
counter to drain before proceeding and freeing pages.

However, swap_pager_swapoff_object() decrements the counter before
re-acquiring the VM object lock, which means that vm_object_terminate()
can race to acquire the lock and free the pages. Then,
swap_pager_swapoff_object() ends up unbusying a freed page. Fix the
problem by acquiring the lock before waking up sleepers.

PR: 273610
Reported by: Graham Perrin <grahamperrin@gmail.com>
Reviewed by: kib
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D42029

(cherry picked from commit e61568aeeec7667789e6c9d4837e074edecc990e)

Details

Provenance
markjAuthored on Oct 2 2023, 11:49 AM
Reviewer
kib
Differential Revision
D42029: swap pager: Fix a race in swap_pager_swapoff_object()
Parents
rG510404f2f49e: nvme: Fix memory leak in pt ioctl commands
Branches
Unknown
Tags
Unknown