HomeFreeBSD

makefs: make msdos creation go fast

Description

makefs: make msdos creation go fast

Add missing brelse(bp). Without it the cache grows and we have a n^2
lookup. I'm not entirely sure why we read the block before we write it
back out, since the only side effect of that is to allocate memory,
clear the memory, read it in from disk, throw it away with the contents
of the file being written out. We likely should just do a getblk() here
instead, but even with all that, this takes the time it takes to create
a 150MB msdos fs image down from 5 minutes to 30 seconds.

Old: 317.663u 0.685s 5:18.34 100.0% 198+360k 0+19io 1009pf+0w
New: 7.330u 23.841s 0:31.17 100.0% 198+360k 0+250522io 4pf+0w

See code review for how we got this. tl;dr: netbsd move brelse
into bwrite and we picked up msdos code after that, but not the
move. That change should be picked up later.

Sponsored by: Netflix
Reviewed by: emaste
MFC After: 1 day (13.2 is coming fast)
Differential Revision: https://reviews.freebsd.org/D39025

(cherry picked from commit 370e009188ba90c3290b1479aa06ec98b66e140a)

Details

Provenance
impAuthored on Mar 13 2023, 8:28 PM
Reviewer
emaste
Differential Revision
D39025: makefs: make msdos creation go fast
Parents
rGa14756f5c351: epair: Fix the RSS build
Branches
Unknown
Tags
Unknown