HomeFreeBSD

nvme: Remove pause while resetting

Description

nvme: Remove pause while resetting

After some study of the code and the standard, I think we can just drop
the pause(), unconditionally. If we're not initialized, then there's
nothing to wait for from a software perspective. If we are initialized,
then there might be outstanding I/O. If so, then the qpair 'recovery
state' will transition to WAITING in nvme_ctrlr_disable_qpairs, which
will ignore any interrupts for items that complete before we complete
the reset by setting cc.en=0.

If we go on to fail the controller, we'll cancel the outstanding I/O
transactions. If we reset the controller, the hardware throws away
pending transactions and we retry all the pending I/O transactions. Any
transactions that happend to complete before cc.en=0 will have the same
effect in the end (doing the same transaction twice is just inefficient,
it won't affect the state of the device any differently than having done
it once).

The standard imposes no wait times here, so it isn't needed from that
perspective.

Unanswered Question: Do we may need to disable interrupts while we
disable in legacy mode since those are level-sensitive.

Sponsored by: Netflix
Reviewed by: mav
Differential Revision: https://reviews.freebsd.org/D32248

(cherry picked from commit e5e26e4a24a1142e02a9b477877e13ed0c194f36)

Details

Provenance
impAuthored on Oct 1 2021, 5:09 PM
mavCommitted on Jan 21 2022, 2:07 AM
Reviewer
mav
Differential Revision
D32248: nvme: Remove pause while resetting
Parents
rG0c3d88b9ab38: nvme: Explain a workaround a little better
Branches
Unknown
Tags
Unknown