HomeFreeBSD

Update SAs when an inode is dirtied

Description

Update SAs when an inode is dirtied

Revert the portion of commit d3aa3ea which always resulted in the
SAs being update when an mmap()'ed file was closed. That change
accidentally resulted in unexpected ctime updates which upset tools
like git. That was always a horrible hack and I'm happy it will
never make it in to a tagged release.

The right fix is something I initially resisted doing because I
was worried about the additional overhead. However, in hindsight
the overhead isn't as bad as I feared.

This patch implemented the sops->dirty_inode() callback which is
unsurprisingly called when an inode is dirtied. We leverage this
callback to keep the znode SAs strictly in sync with the inode.

However, for now we're going to go slowly to avoid introducing
any new unexpected issues by only updating the atime, mtime, and
ctime. This will cover the callpath of most concern to us.

->filemap_page_mkwrite->file_update_time->update_time->
    mark_inode_dirty_sync->__mark_inode_dirty->dirty_inode

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #764
Closes #1140

Details

Provenance
Brian Behlendorf <behlendorf1@llnl.gov>Authored on Dec 12 2012, 12:58 AM
Parents
rGbd192c4f4831: Update 69-vdev.rules .gitignore
Branches
Unknown
Tags
Unknown

Event Timeline

Brian Behlendorf <behlendorf1@llnl.gov> committed rG8780c53961e6: Update SAs when an inode is dirtied (authored by Brian Behlendorf <behlendorf1@llnl.gov>).Dec 14 2012, 8:18 PM