HomeFreeBSD

msk: Use a void cast to mark values of dummy reads as unused.

Description

msk: Use a void cast to mark values of dummy reads as unused.

Note that this required adding missing ()'s around the outermost level
of MSK_READ_MIB*. Otherwise, the void cast was only applied to the
first register read. This also meant that MSK_READ_MIB64 was pretty
broken as the uint64_t cast only applied to the first 16-bit register
read in each MSK_READ_MIB32 invocation and the 32-bit shift was only
applied to the second register read of the pair.

Reviewed by: imp, emaste
Reported by: GCC -Wunused-value
Differential Revision: https://reviews.freebsd.org/D36777

(cherry picked from commit ae70e8838c6673850098530f23ce1521328f983c)

Details

Provenance
jhbAuthored on Oct 5 2022, 11:46 PM
Reviewer
imp
Differential Revision
D36777: msk: Use a void cast to mark values of dummy reads as unused.
Parents
rGd77e67e9d5e4: msk: Don't bother reading spare stats registers.
Branches
Unknown
Tags
Unknown