HomeFreeBSD

tcpdump: ppp: Use the buffer stack for the de-escaping buffer

Description

tcpdump: ppp: Use the buffer stack for the de-escaping buffer

This both saves the buffer for freeing later and saves the packet
pointer and snapend to be restored when packet processing is complete,
even if an exception is thrown with longjmp.

This means that the hex/ASCII printing in pretty_print_packet()
processes the packet data as captured or read from the savefile, rather
than as modified by the PPP printer, so that the bounds checking is
correct.

That fixes CVE-2024-2397, which was caused by an exception being thrown
by the hex/ASCII printer (which should only happen if those routines are
called by a packet printer, not if they're called for the -X/-x/-A
flag), which jumps back to the setjmp() that surrounds the packet
printer. Hilarity^Winfinite looping ensues.

Also, restore ndo->ndo_packetp before calling the hex/ASCII printing
routine, in case nd_pop_all_packet_info() didn't restore it.

Reviewed by: emaste

(cherry picked from commit f8860353d4f4c25bacdae5bc1cfb7a95edc9bfe0)

Details

Provenance
guy_alum.mit.eduAuthored on Tue, Sep 3, 5:11 PM
jrmCommitted on Mon, Sep 9, 7:38 PM
Parents
rG7eb0b02bc4ed: contrib/tzdata: import tzdata 2024b
Branches
Unknown
Tags
Unknown