Diffusion FreeBSD src repository 47b248ac6516

Make locking assertions for VOP_FSYNC() and VOP_FDATASYNC() more correct
47b248ac6516
Actions

Tags

None

Referenced Files

None

Subscribers

None

Description

Make locking assertions for VOP_FSYNC() and VOP_FDATASYNC() more correct

For devfs vnodes, it is fine to not lock vnodes for VOP_FSYNC().
Otherwise vnode must be locked exclusively, except for MNT_SHARED_WRITES()
where the shared lock is enough.

Reported and tested by: pho
Reviewed by: markj
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Differential revision: https://reviews.freebsd.org/D32761

Details

Provenance

kib	Authored on Nov 3 2021, 10:28 PM

Reviewer

Differential Revision

D32761: DEBUG_VFS_LOCKS: stop excluding devfs and doomed vnode from asserts

Parents

rGd1d675cb304c: freevnode(): lock the freeing vnode around destroy_vpollinfo()

Branches

Unknown

Tags

Unknown

Event Timeline

kib committed rG47b248ac6516: Make locking assertions for VOP_FSYNC() and VOP_FDATASYNC() more correct (authored by kib).Nov 12 2021, 11:02 PM

kib added an edge: D32761: DEBUG_VFS_LOCKS: stop excluding devfs and doomed vnode from asserts.Nov 12 2021, 11:06 PM

kib mentioned this in rGb9283ea323b2: Make locking assertions for VOP_FSYNC() and VOP_FDATASYNC() more correct.Nov 19 2021, 4:37 AM

Changes (3)

Path

Size

sys/

kern/

sys/

rG47b248ac6516

sys/kern/vfs_subr.c

Loading...

sys/kern/vnode_if.src

Loading...

sys/sys/vnode.h

Loading...