HomeFreeBSD

Remove splclock(). It's not useful to keep.

Description

Remove splclock(). It's not useful to keep.

splclock is used in one driver (spkr) to control access to
timer_spkr_* routines. However, nothing else does. So it shows no
useful locking info to someone that would want to lock spkr.

NOTE: I think there's races with timer_spkr_{acquire,release} since there's no interlock in those routines, despite there being a spin lock to protect the clock. Current other users appear to use no extra locking protocol, though they themselves appear to be at least attempting to make sure that only a single thread calls these routines. I suspect the right answer is to update these routines to take/release the clock spin lock since they are short and to the point, but that's beyond the scope of this commit.

Details

Provenance
impAuthored on Aug 28 2020, 4:40 PM
Parents
rG1cffe8b812e5: sh: Keep ignored SIGINT/SIGQUIT after set in a background job
Branches
Unknown
Tags
Unknown

Event Timeline