HomeFreeBSD

Illumos 5056 - ZFS deadlock on db_mtx and dn_holds

Description

Illumos 5056 - ZFS deadlock on db_mtx and dn_holds

5056 ZFS deadlock on db_mtx and dn_holds
Author: Justin Gibbs <justing@spectralogic.com>
Reviewed by: Will Andrews <willa@spectralogic.com>
Reviewed by: Matt Ahrens <mahrens@delphix.com>
Reviewed by: George Wilson <george.wilson@delphix.com>
Approved by: Dan McDonald <danmcd@omniti.com>

References:

https://www.illumos.org/issues/5056
https://github.com/illumos/illumos-gate/commit/bc9014e

Porting Notes:

sa_handle_get_from_db():

  • the original patch includes an otherwise unmentioned fix for a possible usage of an uninitialised variable

dmu_objset_open_impl():

  • Under Illumos list_link_init() is the same as filling a list_node_t with NULLs, so they don't notice if they miss doing list_link_init() on a zero'd containing structure (e.g. allocated with kmem_zalloc as here). Under Linux, not so much: an uninitialised list_node_t goes "Boom!" some time later when it's used or destroyed.

dmu_objset_evict_dbufs():

  • reduce stack usage using kmem_alloc()

Ported-by: Chris Dunlop <chris@onthe.net.au>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>

Details

Provenance
gibbsAuthored on Apr 2 2015, 3:44 AM
Brian Behlendorf <behlendorf1@llnl.gov>Committed on Apr 28 2015, 11:25 PM
Parents
rGd683ddbb7272: Illumos 5314 - Remove "dbuf phys" db->db_data pointer aliases in ZFS
Branches
Unknown
Tags
Unknown