User Details
- User Since
- Jan 8 2018, 10:05 PM (331 w, 5 d)
Fri, May 10
updated diff -U 99999
Updated diff -U99999
Thu, May 9
Updated with PR comments
Thu, May 2
Updated for -U99999 as requested.
Could this be imported as is, and then when the hash modules are in and exported it could be switched over?
I believe I have addressed all of reviews; it would be great to get this in for 14.1 so I don't keep having to patch my local copies
Apr 18 2024
Updated with all PR comments, save 1.
Aug 26 2023
- Updated documentation
- refactored tests to make them easier to add to.
Updated diff with all comments addressed, specifically:
- hashes.lua removed and moved into crypt.lua with no reexport
- tests refactored
- tests for NIST vectors for SHA256/512 added (and verified)
- added "crypt:" prefix on password
Aug 23 2023
Thinking about this, I can make a couple of changes that could make this more palatable:
Aug 20 2023
These have existed for decades and pretty much every boot loader and every link in the booting process has optional passwords in place as a check against random people interfering with the boot process. BIOS has it, openboot has it, grub has it.
Uncomfortable how? This is a very straightforward implementation of SHA256/SHA512 modeled after existing LUA SHA2 libraries. I only reimplemented because:
- existing ones were based on lua <5.4 and relied on the bit32 library which is not in LUA54
- were vastly overcomplicated and not BSD licensed (ones that worked on every version of LUA and included multiple different sub-implementations optimized for a vast number of possible LUA configurations.)
- were incapable of being used in this context (they would return hex encoded values, where the crypt(3) algorithms require the raw binary to feed into subsequent stages
Aug 19 2023
Aug 4 2023
Cleaned up erroneous patches due to my tree being out of date with target.
Ran entire kyua test suite as follows:
Updates from code review