Page MenuHomeFreeBSD
Differential D7357

Fix build if gcc has also been build
ClosedPublic
Actions

Authored by bapt on Jul 28 2016, 10:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 9:22 PM
Unknown Object (File)
Sep 26 2024, 6:06 PM
Unknown Object (File)
Sep 17 2024, 7:29 PM
Unknown Object (File)
Sep 8 2024, 6:32 PM
Unknown Object (File)
Sep 7 2024, 8:17 PM
Unknown Object (File)
Sep 7 2024, 6:48 PM
Unknown Object (File)
Sep 2 2024, 4:13 PM
Unknown Object (File)
Aug 20 2024, 11:55 AM
View All 76 Files
Subscribers
imp

Details

Reviewers
emaste
Commits
rS307689: Fix building of llvm's unwind if gcc has been also built
Summary

If gcc has been built, there will be a unwind.h under gnu/usr.bin/cc/cc_tools by
which is included before the llvm unwind header.

Fix it my move the include after

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bapt updated this revision to Diff 18862.Jul 28 2016, 10:35 PM
bapt retitled this revision from to Fix build if gcc has also been build.
bapt updated this object.
bapt edited the test plan for this revision. (Show Details)
bapt added a reviewer: emaste.
Herald added a subscriber: imp. · View Herald TranscriptJul 28 2016, 10:35 PM
emaste added inline comments.Aug 1 2016, 7:56 PM
gnu/lib/libgcc/Makefile
109 ↗(On Diff #18862)

I think it would be useful to have a comment here explaining why cc_tools is included here

emaste accepted this revision.Aug 24 2016, 5:19 PM
emaste edited edge metadata.

LGTM but I think a comment would be good to have.

This revision is now accepted and ready to land.Aug 24 2016, 5:19 PM
Closed by commit rS307689: Fix building of llvm's unwind if gcc has been also built (authored by bapt). · Explain WhyOct 20 2016, 9:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
gnu/
lib/
libgcc/
9 lines

Diff 21559

View Options

head/gnu/lib/libgcc/Makefile

Loading...